stream.hls: refactor queue deadline logic#6734
Merged
bastimeyer merged 3 commits intoNov 23, 2025
Merged
Conversation
Rename `hls-segment-queue-threshold` to `stream-segmented-queue-deadline` and deprecate the old session option and respective CLI argument.
- Move `check_queue_deadline()` to `SegmentedStreamWorker` base class - Add `_queue_deadline_wait` property for subclasses to override - Add queue deadline check to `DASHStreamWorker.iter_segments()` for dynamic manifests with `SegmentList` representations (polling)
14b07b1 to
3769eca
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #6340
This deprecates
--hls-segment-queue-thresholdin favor of--stream-segmented-queue-deadline(and respective session option). The implementation logic remains the same and now also applied to DASH streams (not too useful here though).The CLI argument help text should also be much more clear now.