session.http: refactor HTTP session options#6795
Merged
bastimeyer merged 5 commits intoJan 26, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTPSessionoptions that require special logic should not be set by theStreamlinkOptionsclass. This PR therefore moves the logic into newHTTPSessionclass methods where it actually belongs and also fixes two minor things: lost network interface information when disabling DH key exchange (since a new HTTPS adapter will be mounted) and slightly broken unset logic for theipv4/ipv6session options (which is irrelevant for the CLI, as it can only set).This branch is meant as a preparation for #6792, which will be rebased after merging to master, as that work also adds a new class method for loading cookies from a file. These issues here were noticed while working on #6792.