build: add typing-extensions runtime dep on py310#6813
Merged
bastimeyer merged 1 commit intoFeb 3, 2026
Conversation
Streamlink requires `exceptiongroup` as a runtime dependency on py310. With `exceptiongroup ==1.3.0` (2025-05-10), this implicitly added `typing-extensions >=4.6.0` as a transitive runtime dependency: agronholm/exceptiongroup@2a84dfd5599b We accidentally relied on this implicit transitive runtime dependency on py310 when 8a0bd07 was merged in Streamlink 8.1.0 (2025-12-13). To fix this implicit runtime dependency, add `typing-extensions >=4.1.0` on py310 due to lack of `typing.dataclass_transform` in the stdlib. See PEP 681. We could alternatively backport the `dataclass_transform` decorator and remove it again when support for py310 ends in October 2026, but since we already depend on `exceptiongroup` for backporting reasons, there is no need to, unless they declare `typing-extensions` as a non-runtime dependency in the meantime.
f611b3e to
7120366
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Streamlink requires
exceptiongroupas a runtime dependency on py310.With
exceptiongroup ==1.3.0(2025-05-10), this implicitly addedtyping-extensions >=4.6.0as a transitive runtime dependency:agronholm/exceptiongroup@2a84dfd5599b
We accidentally relied on this implicit transitive runtime dependency on py310 when 8a0bd07 was merged in Streamlink 8.1.0 (2025-12-13).
To fix this implicit runtime dependency, add
typing-extensions >=4.1.0on py310 due to lack oftyping.dataclass_transformin the stdlib.See PEP 681.
We could alternatively backport the
dataclass_transformdecorator and remove it again when support for py310 ends in October 2026, but since we already depend onexceptiongroupfor backporting reasons, there is no need to, unless they declaretyping-extensionsas a non-runtime dependency in the meantime.