plugin: add missing typing info#6822
Merged
Merged
Conversation
ca12083 to
a8ae9dd
Compare
a8ae9dd to
267ad2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds missing typing info to various
Pluginmethods and utility functions, with additional typing fixes in a few plugin implementations. It also turnsPlugininto an abstract base class with_get_streams()now being an abstract method.The second to last commit fully type-annotates
Plugin.streams(). This required a tiny bit of refactoring. The duplicateisinstanceruntime checks are due to ty's type narrowing, which unlike mypy, makes additional assumptions about potential type inheritence.https://docs.astral.sh/ty/reference/typing-faq/#what-is-toplistunknown-and-why-does-it-appear
https://docs.astral.sh/ty/features/type-system/#top-and-bottom-materializations