plugins.twitch: fix stream names on usher v2#6847
Merged
bastimeyer merged 1 commit intoMar 1, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6846
See #6840
I should've been more careful in #6840, because I totally missed that no
EXT-X-MEDIAtags were present, leading to media playlists not having anameproperty. We currently don't parse theFRAME-RATEattribute onEXT-X-STREAM-INFtags (I just realized it), so thepixelsname only gets its value from the video resolution height.Since the
audio_onlystream on Twitch doesn't have aRESOLUTIONattribute, it's named after its stream bitrate.In order to not introduce any changes in other plugins for now, I decided to add an override to the Twitch plugin, which artificially adds
Mediadata to the media playlists, so the right name is chosen, which is set by Twitch itself. An override for theaudio_onlystream would've been needed anyway.Now we have properly names streams/qualities on live streams. As said, I missed that in #6840 and got confused, because VODs already had the right name. The
audio_onlyvsaudiodifference has always been there.