plugins.nicolive: WS reconnect on HLS key failure#6871
Merged
bastimeyer merged 2 commits intoMar 26, 2026
Merged
Conversation
|
I installed this pull request branch and tested it with several live streams. As a result, I confirmed that everything worked correctly. Thank you very much for your work—my sincere appreciation for your efforts! |
Member
Author
|
@monakanamo Thanks for testing. Please post a full debug log of a working websocket reconnect, as requested. |
|
Since I’m not exactly sure which part of the logs is required, I will include the logs from the start of the recording until it is stopped by pressing Ctrl+C. |
Member
Author
|
This is what I was interested in. Since these are two separate video and audio streams that need to be muxed into a single output stream, it's possible that the decyption key requests of each of them can trigger a reconnect at the same time from both threads. This is the case here, which leads to an error in the websocket client which fortunately can be recovered from. This still should be fixed though. Going to have a look now... |
6d1352b to
2b5f773
Compare
Member
Author
|
Please re-test and see if there are any double reconnect attempts. Those won't be logged anymore. The updated PR branch HEAD is now 2b5f773, meaning the version string should be Duplicate reconnect() calls should now be avoided until the websocket reconnection has finished. This doesn't mean though that timing issues can't occur anymore, for example when a decryption key request of the second writer thread failed just after the websocket was reconnected from the first thread where a decryption key retrieval failed. But that shouldn't be a problem. And I don't think those can't be prevented anyway. |
Member
Author
|
@monakanamo please re-test with a debug log once you get the time, so I can merge the changes into the master branch. |
|
Sorry for the late reply. |
Member
Author
|
Well... There's only one decryption key failure in your log, so it's unfortunately not useful. I'm going to merge this anyway now. If there are any errors, please report them if you encounter them. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6870
@monakanamo
Please test a couple of streams and report back with a debug log, so I can see that it's working correctly. You'll have to install from this PR branch (you can't sideload the updated plugin), as there's another commit which updates the
WebsocketClientimplementation.https://github.com/streamlink/streamlink/blob/master/CONTRIBUTING.md#pull-request-feedback