Thanks to visit codestin.com
Credit goes to github.com

Skip to content

plugins.twitcasting: filter preroll on segment map#6910

Merged
bastimeyer merged 1 commit into
streamlink:masterfrom
bastimeyer:plugins/twitcasting/preroll-segment-map
Apr 29, 2026
Merged

plugins.twitcasting: filter preroll on segment map#6910
bastimeyer merged 1 commit into
streamlink:masterfrom
bastimeyer:plugins/twitcasting/preroll-segment-map

Conversation

@bastimeyer

Copy link
Copy Markdown
Member

Fixes #6909

@Lytexx please check and see if this misses some streams. As you can see, this filters segments whose map-segment matches -\d+\.\w+$ (notice the leading dash / minus sign). I don't know how reliable this approach is.

@bastimeyer bastimeyer added the plugin issue A Plugin does not work correctly label Apr 26, 2026
@bastimeyer bastimeyer force-pushed the plugins/twitcasting/preroll-segment-map branch from ffe527d to 4eb6835 Compare April 26, 2026 15:28
@bastimeyer

Copy link
Copy Markdown
Member Author

Why did the ruff format step fail? It passes on my system using the same version of ruff... What?!

@Lytexx

Lytexx commented Apr 26, 2026

Copy link
Copy Markdown

looks good, I tried it on a few streams from the frontpage and had no issues, it also filters out the preroll segments correctly

@bastimeyer bastimeyer merged commit 4f9855c into streamlink:master Apr 29, 2026
31 checks passed
@bastimeyer bastimeyer deleted the plugins/twitcasting/preroll-segment-map branch April 29, 2026 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin issue A Plugin does not work correctly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

plugins.twitcasting: preroll breaks recording again

2 participants