Fix visualization of disabled feedback #10030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-bnisco
approved these changes
Dec 16, 2024
edegp
pushed a commit
to edegp/streamlit
that referenced
this pull request
Jan 19, 2025
## Describe your changes When a feedback widget was selected but also disabled, the selection was not recognizable visually anymore. This PR here fixes that to keep a visual indication also for disabled feedback widgets when selected. The e2e test is updated to show the enabled and disabled widget state together with a selection in taken snapshots. ## GitHub Issue Link (if applicable) ## Testing Plan - E2E Tests - Updates to account for selected feedback widgets that are disabled in snapshots --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
When a feedback widget was selected but also disabled, the selection was not recognizable visually anymore. This PR here fixes that to keep a visual indication also for disabled feedback widgets when selected.
The e2e test is updated to show the enabled and disabled widget state together with a selection in taken snapshots.
Before:
After:
GitHub Issue Link (if applicable)
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.