Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update chat input send button hover UI #10048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sfc-gh-pchiu merged 5 commits into from
Dec 20, 2024
Merged

Update chat input send button hover UI #10048

sfc-gh-pchiu merged 5 commits into from
Dec 20, 2024

Conversation

@sfc-gh-pchiu
Copy link
Contributor

@sfc-gh-pchiu sfc-gh-pchiu commented Dec 19, 2024 •
edited
Loading

Describe your changes

Updating the chat input's border radii as part of our new design to introduce file upload for chat.

  • Changed icon to primary when hovered instead of the background
  • Added a test case to test the hover state
  • Note that the border radii of the hovered button is changed in Update chat input widget border radius #10047 -- with its top-left corner keeping the default radius

GitHub Issue Link (if applicable)

Testing Plan

  • E2E Tests

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@sfc-gh-pchiu sfc-gh-pchiu added security-assessment-completed Security assessment has been completed for PR change:feature PR contains new feature or enhancement implementation impact:users PR changes affect end users labels Dec 19, 2024
@sfc-gh-pchiu sfc-gh-pchiu marked this pull request as ready for review December 19, 2024 19:06
lukasmasuch
lukasmasuch approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@lukasmasuch lukasmasuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sfc-gh-pchiu sfc-gh-pchiu merged commit 003c969 into develop Dec 20, 2024
32 checks passed
@sfc-gh-pchiu sfc-gh-pchiu deleted the chat-input-send-hover branch December 20, 2024 16:22
@sfc-gh-pchiu sfc-gh-pchiu mentioned this pull request Jan 3, 2025
Merged
edegp pushed a commit to edegp/streamlit that referenced this pull request Jan 19, 2025
@sfc-gh-pchiu @edegp
Update chat input send button hover UI (streamlit#10048)
dd88699
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukasmasuch lukasmasuch lukasmasuch approved these changes

@kajarenc kajarenc Awaiting requested review from kajarenc

Assignees

No one assigned

Labels

change:feature PR contains new feature or enhancement implementation impact:users PR changes affect end users security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sfc-gh-pchiu @lukasmasuch