In st.multiselect, make mouse cursor only be a pointer when hovering the X #10087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-bnisco
approved these changes
Jan 6, 2025
edegp
pushed a commit
to edegp/streamlit
that referenced
this pull request
Jan 19, 2025
…the X (streamlit#10087) ## Describe your changes Today, when you hover over any part of a selected item in an `st.multiselect` you get a "👆" cursor. This is confusing because the only part of a selected item that's actually interactive is the "×" icon. With this PR, only the "×" icon of an `st.multiselect` will show a "👆" cursor on hover. ### Before https://github.com/user-attachments/assets/65f5dec1-484a-468c-929e-3b519d78d7ae ### After https://github.com/user-attachments/assets/f54cd611-3e12-43cb-83ae-a6bf5daa6ccb ## GitHub Issue Link (if applicable) None ## Testing Plan - Explanation of why no additional tests are needed: not sure if there's a good way to test this. Also: is it even worth tests? Not sure we should be testing _every_ cursor behavior in Streamlit... - Unit Tests (JS and/or Python): No - E2E Tests: No - Any manual testing needed? **I'm not sure...** Might be good to make sure this works as intended in all browsers and OSes. But I'm not doing anything crazy here, so not really required. --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Today, when you hover over any part of a selected item in an
st.multiselectyou get a "👆" cursor. This is confusing because the only part of a selected item that's actually interactive is the "×" icon.With this PR, only the "×" icon of an
st.multiselectwill show a "👆" cursor on hover.Before
old.mov
After
new.mov
GitHub Issue Link (if applicable)
None
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.