Force react-syntax-highlighter to cjs build #10244
Conversation
|
|
||
| .PHONY: frontend-fast | ||
| frontend-fast: | ||
| cd frontend/ ; yarn workspace @streamlit/app buildFast |
There was a problem hiding this comment.
This no longer exists, so I updated it.
There was a problem hiding this comment.
Do we even still need frontend-fast? Is it faster compared to make frontend?
There was a problem hiding this comment.
Eh. make frontend builds everything. make frontend-build-with-profiler is fast with profiler. There is make frontend-app, but it does not copy over the files.
I used it in testing cause it was the easiest way for me to build the app frontend and copy it over with no profiling. There's probably opportunities to clean it up. Perhaps when we talk about cleaning up the makefile.
raethlein
left a comment
There was a problem hiding this comment.
This fix seems to work for me 👍 ✅
Great work!
I was able to constantly reproduce the issue when opening the Streamlit app with a production build in a new tab, then go to a different tab, right-click on the original Streamlit tab and click 'Reload', go back to the Streamlit tab and see that the code block is rendered in the wrong way.
Now, I don't seem to be able to reproduce it with the fix.
Describe your changes
There are issues with react-syntax-highlighter as an ESM module with Vite. As a result, we explicitly choose the common js format in order to fix the issue.
The steps here react-syntax-highlighter/react-syntax-highlighter#565 help illustrate the issue
GitHub Issue Link (if applicable)
closes #10231
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.