Allow hiding dataframe columns from UI #10264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const hideColumn = React.useCallback( | ||
| (columnId: string) => { | ||
| setColumnConfigMapping(prevColumnConfigMapping => { | ||
| const newColumnConfigMapping = new Map(prevColumnConfigMapping) |
Collaborator
There was a problem hiding this comment.
Why do we need to create a new map object here? (Not suggesting it is wrong, just to understand).
Collaborator
Author
There was a problem hiding this comment.
Good question. I'm not 100% sure why I wrapped that into a new map. It was something I already did in some similar merged code, but I think we can remove it. I will probably do it in a follow up PR since its now part of a utils function.
sfc-gh-lwilby
approved these changes
Feb 22, 2025
|
|
||
| const showColumn = React.useCallback( | ||
| (columnId: string) => { | ||
| setColumnConfigMapping(prevColumnConfigMapping => { |
Collaborator
There was a problem hiding this comment.
Just thinking this function could be pulled into a helper function. I guess it is a bit different then the logic in the other PR although shared between showColumn and hideColumn.
…e-column-visibility-menu
…e-column-visibility-menu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Allow users to show & hide dataframe columns from UI via the column menu:
This also adds a new toolbar action that allows showing & hiding all columns of the dataframe:
GitHub Issue Link (if applicable)
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.