Remove rich from required dependencies
#10320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-bnisco
approved these changes
Feb 3, 2025
lukasmasuch
added a commit
that referenced
this pull request
Mar 5, 2025
## Describe your changes We recently removed rich as a required dependency in #10320. This PR automatically enable better exception logging if `rich` is installed in the local environment, instead of also requiring the config option to be configured. This is mainly targeted for community cloud to simplify their configuration, but might also be useful for some users. ## Testing Plan - Updated tests to validate that `rich` is activated if `rich` is installed (which is the case in our testing environment) --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
We have a Python dependency in Streamlit -
rich- that is almost exclusively used in Community Cloud to get nicer formatting for exceptions in the log viewer. However, it is currently installed for all Streamlit installs, which is suboptimal. The dependency is already implemented in Streamlit in a way that it is optional (only used if installed). We have recently changed thatrichgets auto-installed on Community Cloud, therefore, we can remove it from Streamlit's required dependencies.In a follow-up after the release, we also plan to deprecate and eventually remove the
logger.enableRichconfig option and always userichif installed.Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.