Add autosize option to dataframe column menu #10476
Conversation
| open_column_menu(df, 0, "small") | ||
| app.get_by_test_id("stDataFrameColumnMenu").get_by_text("Autosize").click() | ||
| unfocus_dataframe(app) | ||
| # Use the same screenshots as above since we expect the same |
There was a problem hiding this comment.
Which screenshot as above? I did not find any screenshot with the same name
There was a problem hiding this comment.
Oh, sorry... the comment is wrong here :(
There was a problem hiding this comment.
I added a small improvement to the test to ensure that the new dataframe is smaller than the old one
| }) | ||
| }) | ||
|
|
||
| describe("autosize functionality", () => { |
There was a problem hiding this comment.
would it somehow be possible to test that autosizing actually works? Maybe by manually setting the width of a column to a certain value, then click on the Autosize button and then compare the widths? Could also be done in an e2e test
There was a problem hiding this comment.
It would be very hard to do that in RTL tests, but I added an e2e test already that shows that auto-sizing works. I can improve the e2e tests a bit more.
raethlein
left a comment
There was a problem hiding this comment.
LGTM! Just left two minor comments about tests
Describe your changes
Add a new option to the dataframe column menu to auto-size a given column based on its content:
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.