Revamp the dataframe search bar to be more responsive #10534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raethlein
reviewed
Feb 27, 2025
| "& .gdg-seveqep": { | ||
| // Make the search field more responsive to the grid width and use | ||
| // rem units for everything. | ||
| maxWidth: "19rem", |
Collaborator
There was a problem hiding this comment.
Could you please leave a comment about how we landed at 19rem? Even if it is just We picked 19rem arbitrarily because it looked good on a laptop screen or whatever. This will help others in the future in case this has to be revisited
Collaborator
Author
There was a problem hiding this comment.
Sounds good, added some comments 👍
raethlein
reviewed
Feb 27, 2025
| // rem units for everything. | ||
| maxWidth: "19rem", | ||
| width: "80%", | ||
| minWidth: "6rem", |
Collaborator
There was a problem hiding this comment.
Collaborator
Author
There was a problem hiding this comment.
Added comments 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Makes the dataframe search bar more responsive to the available width and to the root font size.
GitHub Issue Link (if applicable)
st.dataframeresponsive #10532Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.