Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@lukasmasuch
Copy link
Collaborator

@lukasmasuch lukasmasuch commented Feb 27, 2025

Describe your changes

  • Updated node-emoji to the latest versions.
  • Use emoji embedded in SVG instead of outdated twemoji CDN. SVG favicons are supported in all major browsers, excluding Safari. But the current emoji favicon support also doesn't work in Safari (see set_page_config page icons do not work in Safari #2514).

GitHub Issue Link (if applicable)

Testing Plan

  • Updated tests

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

dependabot bot and others added 2 commits February 27, 2025 10:02
Bumps [node-emoji](https://github.com/omnidan/node-emoji) and [@types/node-emoji](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node-emoji). These dependencies needed to be updated together.

Updates `node-emoji` from 1.11.0 to 2.2.0
- [Release notes](https://github.com/omnidan/node-emoji/releases)
- [Changelog](https://github.com/omnidan/node-emoji/blob/main/CHANGELOG.md)
- [Commits](omnidan/node-emoji@v1.11.0...v2.2.0)

Updates `@types/node-emoji` from 1.8.2 to 2.1.0
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node-emoji)

---
updated-dependencies:
- dependency-name: node-emoji
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: "@types/node-emoji"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@lukasmasuch lukasmasuch added security-assessment-completed Security assessment has been completed for PR change:feature PR contains new feature or enhancement implementation impact:users PR changes affect end users labels Feb 27, 2025
@lukasmasuch lukasmasuch changed the title Update emoji support and dependencies [WIP] Update emoji support and dependencies Feb 27, 2025
@lukasmasuch lukasmasuch marked this pull request as ready for review February 27, 2025 14:19
@lukasmasuch lukasmasuch changed the title [WIP] Update emoji support and dependencies Update emoji support and dependencies Feb 27, 2025
Copy link
Collaborator

@mayagbarnes mayagbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼
Just confirming - not closing #9095 enhancement since the 2.0 version upgrade/addition of skin-tone dependency just paves the way for skin-tone support right?

@lukasmasuch
Copy link
Collaborator Author

Just confirming - not closing #9095 enhancement since the 2.0 version upgrade/addition of skin-tone dependency just paves the way for skin-tone support right?

mainly because we cannot yet update remark-emoji to the latest versions :( needs a few bigger changes to our markdown logic.

@lukasmasuch lukasmasuch merged commit 219e567 into develop Feb 27, 2025
32 checks passed
@lukasmasuch lukasmasuch deleted the update-emoji-support branch February 27, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:feature PR contains new feature or enhancement implementation impact:users PR changes affect end users security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UX Consistency: Add an option in set_page_config to replace OS/browser default emoji font with Twemoji

3 participants