[Fix] Disable scroll within st.number_input
#10642
Merged
+29
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasmasuch
reviewed
Mar 5, 2025
| if (numberInput) { | ||
| // Issue #8867: Disable wheel events on the input to avoid accidental changes | ||
| // caused by scrolling. | ||
| numberInput.addEventListener("wheel", e => e.preventDefault()) |
Collaborator
There was a problem hiding this comment.
Do you know where the wheel feature is implemented? Is it in baseweb or is it a basic html number input feature?
Collaborator
Author
There was a problem hiding this comment.
Its coming from the basic html number input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Disables the
"wheel"event on number inputs to avoid accidental modification ofst.number_inputvalue while scrollingGitHub Issue Link (if applicable)
Closes #8867
Testing Plan