[Fix]: st.page_link - current vs. non-current page visuals & width
#10690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st.page_link - current vs. non-current page visuals & width st.page_link - current vs. non-current page visuals & width
kmcgrady
approved these changes
Mar 10, 2025
sfc-gh-bnisco
approved these changes
Mar 10, 2025
sfc-gh-mbarnes
pushed a commit
that referenced
this pull request
Mar 11, 2025
…10690) Ensure `currentPageScriptHash` set in `App` & populated in `LibContext` for SPA - `currentPageScriptHash` blank for SPAs - so `st.page_link` renders every page as if its the current page: Fix styling for `st.page_link` when `help` & `use_container_width = "true"` - [#10640](#10658) addresses part of the issue with width for `st.page_link` but also need to handle width in `StyledNavLinkContainer` Add dedicated e2e/snapshot testing for `st.page_link` feature (currently only in MPA context) - currently have page link buttons in MPA tests, but to prevent issues in the future, adding SPA tests for `st.page_link` Add more JS unit tests for `st.page_link` params like `icon`, `help`, `use_container_width`, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Ensure
currentPageScriptHashset inApp& populated inLibContextfor SPA -currentPageScriptHashblank for SPAs - sost.page_linkrenders every page as if its the current page:Fix styling for
st.page_linkwhenhelp&use_container_width = "true"- #10640 addresses part of the issue with width forst.page_linkbut also need to handle width inStyledNavLinkContainerAdd dedicated e2e/snapshot testing for
st.page_linkfeature (currently only in MPA context) - currently have page link buttons in MPA tests, but to prevent issues in the future, adding SPA tests forst.page_linkAdd more JS unit tests for
st.page_linkparams likeicon,help,use_container_width, etc.GitHub Issue Link (if applicable)
Closes #10689
Testing Plan