[theming] Use dark mix for hovered color instead of theme.colors.secondaryBg
#10930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Contributor
✅ PR preview is ready!
|
sfc-gh-pchiu
commented
Mar 26, 2025
Contributor
Author
There was a problem hiding this comment.
I did not change bgRowHovered on L122 since it's mixing the bg and secondaryBg colors dynamically. But we may want to revisit if this is the behavior we want.
theme.colors.secondaryBg
sfc-gh-pchiu
commented
Mar 26, 2025
| // Whatever color we use here as the hover state, we want to transparentize it | ||
| // to its full extend, so you can see the underlying color of the menu. | ||
| backgroundColor: transparentize(theme.colors.secondaryBg, 1), | ||
| backgroundColor: transparentize(theme.colors.darkenedBgMix15, 1), |
Contributor
Author
There was a problem hiding this comment.
the color doesn't matter here with full transparency
Collaborator
There was a problem hiding this comment.
Can't we simiplfy this here and just use: `backgroundColor: "transparent"?
Collaborator
|
Two other hover-related places that would also be good to update:
export const ThemedStyledDropdownListItem = styled(StyledDropdownListItem, {
shouldForwardProp: isPropValid,
})(({ theme, $isHighlighted }) => {
return {
display: "flex",
alignItems: "center",
paddingTop: theme.spacing.none,
paddingBottom: theme.spacing.none,
paddingLeft: theme.spacing.lg,
paddingRight: theme.spacing.lg,
background: $isHighlighted ? theme.colors.darkenedBgMix15 : undefined,
// Override the default itemSize set on the component's JSX
// on mobile, so we can make list items taller and scrollable
[`@media (max-width: ${theme.breakpoints.md})`]: {
minHeight: theme.sizes.dropdownItemHeight,
height: "auto !important",
},
"&:hover, &:active, &:focus-visible": {
background: theme.colors.darkenedBgMix15,
},
}
})And maybe also update this one to use |
837366a to
e5b9ef7
Compare
sfc-gh-bnisco
pushed a commit
that referenced
this pull request
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The secondary background color (
theme.colors.secondaryBg,secondaryBackgroundColor...) has historically been used all over the places as a simple way to differentiate an element from the app's background color.This however made it difficult to articulate its purpose when defining custom theming options and we want to gradually revamp it into separated use cases more clearly.
This PR moved all hover (highlight) use cases of the
theme.colors.secondaryBgtotheme.colors.darkenedBgMix15to make it more consistent with the rest of the theming (Note that they are not the exact same gray but are very similar)GitHub Issue Link (if applicable)
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.