[fix] st.html resize handling #10976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Contributor
✅ PR preview is ready!
|
sfc-gh-nbellante
approved these changes
Mar 31, 2025
kmcgrady
approved these changes
Mar 31, 2025
Collaborator
kmcgrady
left a comment
There was a problem hiding this comment.
Left one nit, but looks great!
4 tasks
sfc-gh-bnisco
added a commit
that referenced
this pull request
Mar 31, 2025
## Describe your changes - Utilizes `width: 100%` to ensure the `st.html` content takes up full space - Adds e2e tests to assert behavior ## GitHub Issue Link (if applicable) #10964 ## Testing Plan ✅ Adds e2e tests with snapshots --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
width: 100%to ensure thest.htmlcontent takes up full spaceGitHub Issue Link (if applicable)
#10964
Testing Plan
✅ Adds e2e tests with snapshots
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.