[fix] st.fragment interaction with st.{balloons,snow} #11015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Contributor
✅ PR preview is ready!
|
74938ca to
5b91359
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes the issue where re-runs in st.fragment caused st.balloons and st.snow to reappear unexpectedly. The changes update the ElementNodeRenderer to pass the scriptRunId from node instead of props and add comprehensive end-to-end tests (for both snow and balloons) along with shared animation utilities to verify the correct behavior.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/lib/src/components/core/Block/ElementNodeRenderer.tsx | Updates the scriptRunId prop passed to Balloons and Snow components to use node.scriptRunId for proper fragment interaction. |
| e2e_playwright/st_snow_with_fragment_interactions_test.py | Adds tests to verify that st.snow behaves as expected with fragment re-runs and full page re-runs. |
| e2e_playwright/st_snow_with_fragment_interactions.py | Defines a test component triggering st.snow through a fragment to support the new behavior. |
| e2e_playwright/st_balloons_with_fragment_interactions_test.py | Adds tests to confirm that st.balloons does not reappear after fragment re-runs and reappears on full page re-run. |
| e2e_playwright/st_balloons_with_fragment_interactions.py | Defines a test component triggering st.balloons through a fragment to support the new behavior. |
| e2e_playwright/shared/animation_utils.py | Provides shared utilities for validating the onscreen/offscreen state of animations for use in the tests. |
5b91359 to
cdfe543
Compare
lukasmasuch
reviewed
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
st.fragmentre-runs would causest.{balloons,snow}to show up again.GitHub Issue Link (if applicable)
Fixes #10961
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.