[theming] use markdown text colors for primitives #11033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Contributor
✅ PR preview is ready!
|
lukasmasuch
approved these changes
Apr 4, 2025
Collaborator
lukasmasuch
left a comment
There was a problem hiding this comment.
LGTM 👍
But It might be good to also directly use these colors within getMarkdownTextColors, e.g.:
export function getMarkdownTextColors(theme: EmotionTheme): any {
const lightTheme = hasLightBackgroundColor(theme)
const primary = theme.colors.primary
const red = theme.colors.red
const yellow = theme.colors.yellow
const green = theme.colors.green
const blue = theme.colors.blue
const orange = lightTheme ? theme.colors.orange100 : theme.colors.orange60
const violet = lightTheme ? theme.colors.purple80 : theme.colors.purple50
const purple = lightTheme ? theme.colors.purple100 : theme.colors.purple80
const gray = lightTheme ? theme.colors.gray80 : theme.colors.gray70
....3ccb19a to
bfd112a
Compare
2c8c8d7 to
7975083
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
With guidance from design (and from the discussion here), the PR consolidated the primitive color codes (red/green/blue/etc...) used in our themes with the Markdown text's color so that they are consistent across the app.
Specifically, I replaced red/blue/green/yellow in the base (light) and dark themes with the definition here.
RFC if we need change the gray color as well. I left it out due to it having multiple variants already.
GitHub Issue Link (if applicable)
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.