BugFix 11062: Sidebar resizing #11063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Contributor
✅ PR preview is ready!
|
Collaborator
sfc-gh-bnisco
left a comment
There was a problem hiding this comment.
Thanks for fixing! I have some suggestions/questions inline
- Added a reference for the resizable element to improve width handling. - Updated the onResizeStop callback to use the actual width of the sidebar instead of a delta value, ensuring accurate width adjustments. - Modified the resetSidebarWidth function to reset the sidebar width on double-clicking the resize handle. These changes improve the user experience by providing a more reliable resizing mechanism for the sidebar.
58e0343 to
d6247af
Compare
sfc-gh-bnisco
approved these changes
Apr 15, 2025
Collaborator
sfc-gh-bnisco
left a comment
There was a problem hiding this comment.
Nice, thanks for the revisions! Please update the PR description now that tests have been added.
This was referenced Aug 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This fixes:
GitHub Issue Link (if applicable)
fixes #11062
Testing Plan
E2E tests have been added to lock in this functionality.
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.