Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[feat] Add tab_index to iframe and custom component #11065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sfc-gh-bnisco merged 3 commits into from
Apr 22, 2025
Merged

[feat] Add tab_index to iframe and custom component #11065

sfc-gh-bnisco merged 3 commits into from
Apr 22, 2025

Conversation

@sfc-gh-bnisco
Copy link
Collaborator

@sfc-gh-bnisco sfc-gh-bnisco commented Apr 9, 2025

Describe your changes

  • Adds tab_index arguments to iframe and custom components v1

GitHub Issue Link (if applicable)

Fixes #7969

Testing Plan

  • ✅ Adds Python Unit Tests
  • ✅ Adds JS Unit Tests
  • ✅ Adds e2e tests
  • ✅ Manually tested a custom component locally using the component-template and the locally built wheel file

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@snyk-io
Copy link
Contributor

snyk-io bot commented Apr 9, 2025 •
edited
Loading

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)

@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025 •
edited
Loading

✅ PR preview is ready!

Name Link
📦 Wheel file https://core-previews.s3-us-west-2.amazonaws.com/pr-11065/streamlit-1.44.1-py3-none-any.whl
🕹️ Preview app pr-11065.streamlit.app (☁️ Deploy here if not accessible)

@sfc-gh-bnisco sfc-gh-bnisco added feature:custom-components Related to custom components security-assessment-completed Security assessment has been completed for PR change:feature PR contains new feature or enhancement implementation impact:users PR changes affect end users labels Apr 9, 2025
@sfc-gh-bnisco sfc-gh-bnisco requested a review from Copilot April 10, 2025 16:14
Copilot AI reviewed Apr 10, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

sfc-gh-bnisco
sfc-gh-bnisco commented Apr 10, 2025
View reviewed changes
proto/streamlit/proto/IFrame.proto Outdated
Copy link
Collaborator Author

@sfc-gh-bnisco sfc-gh-bnisco Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: It's a little weird that field number 6 wasn't yet used here. I looked through the Git Blame and don't see it ever being used in the past. From my perspective this should be safe, but I wanted to flag it in case reviewers think I should use a different field number.

Copy link
Contributor

@sfc-gh-nbellante sfc-gh-nbellante Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that does seem strange that 6 was never used 🤔

Copy link
Contributor

@sfc-gh-nbellante sfc-gh-nbellante Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can confirm that i also don't see 6 ever being used. my only thought was it was foresight in case a has_height was ever needed?

@sfc-gh-bnisco sfc-gh-bnisco marked this pull request as ready for review April 10, 2025 17:14
@sfc-gh-bnisco sfc-gh-bnisco requested a review from a team as a code owner April 10, 2025 17:14
sfc-gh-nbellante
sfc-gh-nbellante approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@sfc-gh-nbellante sfc-gh-nbellante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing contentious in my view is the use of 6 vs 8 in the proto. I'd probably use 8 just because there's less arguments against it, but with that being said I don't feel strongly at all about it.

@sfc-gh-bnisco sfc-gh-bnisco merged commit fb7d722 into develop Apr 22, 2025
34 checks passed
@sfc-gh-bnisco sfc-gh-bnisco deleted the bnisco/fix-7969 branch April 22, 2025 16:47
@renovate renovate bot mentioned this pull request Jul 23, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@sfc-gh-nbellante sfc-gh-nbellante sfc-gh-nbellante approved these changes

Assignees

No one assigned

Labels

change:feature PR contains new feature or enhancement implementation feature:custom-components Related to custom components impact:users PR changes affect end users security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow TabIndex setting (with current behavior as default) to support accessibility

3 participants

@sfc-gh-bnisco @sfc-gh-nbellante