Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix encoding #11090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sfc-gh-nbellante merged 1 commit into from
Apr 14, 2025
Merged

Fix encoding #11090

sfc-gh-nbellante merged 1 commit into from
Apr 14, 2025

Conversation

@ashm-dev
Copy link
Contributor

@ashm-dev ashm-dev commented Apr 13, 2025

Describe your changes

  • Added encoding="utf-8" parameter to all .write_text() method calls in the codebase
  • Improved code formatting in the main_init function in cli.py

GitHub Issue Link (if applicable)

#11086

Testing Plan

  • Explanation of why no additional tests are needed
  • Unit Tests (JS and/or Python)
  • E2E Tests
  • Any manual testing needed?

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@snyk-io
Copy link
Contributor

snyk-io bot commented Apr 13, 2025 •
edited
Loading

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)

sfc-gh-lwilby
sfc-gh-lwilby approved these changes Apr 14, 2025
View reviewed changes
Copy link
Collaborator

@sfc-gh-lwilby sfc-gh-lwilby left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this @ashm-dev!

@sfc-gh-lwilby sfc-gh-lwilby added security-assessment-completed Security assessment has been completed for PR change:bugfix PR contains bug fix implementation impact:users PR changes affect end users labels Apr 14, 2025
@sfc-gh-nbellante
Copy link
Contributor

sfc-gh-nbellante commented Apr 14, 2025

I tried to see if we could make a custom rule for ruff to prevent this issue from coming back in the future but it seems ruff does not currently support custom rules. :(

@sfc-gh-nbellante sfc-gh-nbellante merged commit 7c603f8 into streamlit:develop Apr 14, 2025
35 of 36 checks passed
@ashm-dev ashm-dev deleted the fix-11086 branch April 15, 2025 03:55
@sfc-gh-lwilby
Copy link
Collaborator

sfc-gh-lwilby commented Apr 15, 2025

I tried to see if we could make a custom rule for ruff to prevent this issue from coming back in the future but it seems ruff does not currently support custom rules. :(

I was wondering also if a linter rule might be too general and we might have cases where we don't want this behaviour.

Maybe there is a way to mock the environment in a test. @ashm-dev tagging you in case you have ideas on how we might add a test for this as well!

@ashm-dev
Copy link
Contributor Author

ashm-dev commented Apr 17, 2025

I tried to see if we could make a custom rule for ruff to prevent this issue from coming back in the future but it seems ruff does not currently support custom rules. :(

I was wondering also if a linter rule might be too general and we might have cases where we don't want this behaviour.

Maybe there is a way to mock the environment in a test. @ashm-dev tagging you in case you have ideas on how we might add a test for this as well!

Unfortunately, I don't have much experience in testing, and unfortunately I don't have any ideas yet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfc-gh-lwilby sfc-gh-lwilby sfc-gh-lwilby approved these changes

@sfc-gh-nbellante sfc-gh-nbellante sfc-gh-nbellante approved these changes

Assignees

No one assigned

Labels

change:bugfix PR contains bug fix implementation impact:users PR changes affect end users security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ashm-dev @sfc-gh-nbellante @sfc-gh-lwilby