BugFix 11097: Update FontFaceDeclaration to support customizable font styles #11098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Contributor
✅ PR preview is ready!
|
Collaborator
sfc-gh-bnisco
left a comment
There was a problem hiding this comment.
Code change looks good, can we add some e2e snapshot tests for this?
Contributor
Author
|
Note to self: looks like the fonts aren't being properly loaded for the e2e tests. (Look at the f's) |
sfc-gh-bnisco
approved these changes
Apr 15, 2025
- Modified the FontFaceDeclaration component to allow for an optional `style` property in the fontFaces array, defaulting to "normal" if not provided. This change enhances flexibility in font styling for better design adaptability.
…to make it clearer that the proper fonts are being used
…own for stuff that's not needed to reduce filesize and satisfy ruff
4e54bbb to
87ce85a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
styleproperty in the fontFaces array, defaulting to "normal" if not provided. This change enhances flexibility in font styling for better design adaptability.Before
After
GitHub Issue Link (if applicable)
closes #11097
Testing Plan
E2E test added.
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.