Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@mayagbarnes
Copy link
Collaborator

@mayagbarnes mayagbarnes commented Apr 16, 2025

Describe your changes

  • Fix hover styling for disabled Take Photo button - should not change border color for disabled button like below, only if active
Screenshot 2025-04-16 at 1 37 24 p m
  • Fix click styling for disabled Take Photo button - should not change background color for disabled button, and should use not-allowed cursor like other buttons
Screenshot 2025-04-16 at 1 36 28 p m

Testing Plan

  • JS Unit Tests: ✅ Added
  • E2E Tests: ✅ Added
  • Manual Testing: ✅

@mayagbarnes mayagbarnes added security-assessment-completed Security assessment has been completed for PR change:chore PR contains maintenance or housekeeping change impact:users PR changes affect end users labels Apr 16, 2025
@snyk-io
Copy link
Contributor

snyk-io bot commented Apr 16, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@github-actions
Copy link
Contributor

github-actions bot commented Apr 16, 2025

✅ PR preview is ready!

Name Link
📦 Wheel file https://core-previews.s3-us-west-2.amazonaws.com/pr-11116/streamlit-1.44.1-py3-none-any.whl
🕹️ Preview app pr-11116.streamlit.app (☁️ Deploy here if not accessible)

@mayagbarnes mayagbarnes marked this pull request as ready for review April 16, 2025 20:44
@mayagbarnes mayagbarnes merged commit e8cd868 into develop Apr 16, 2025
34 checks passed
@mayagbarnes mayagbarnes deleted the camera-papercuts branch April 16, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:chore PR contains maintenance or housekeeping change impact:users PR changes affect end users security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants