Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Bernardo1008
Copy link
Contributor

@Bernardo1008 Bernardo1008 commented Apr 28, 2025

Describe your changes

Improved the DateInput component by applying custom hover styles for dates that fall within a selected range, being a unique problem for the light theme. Enhances visual clarity and user experience when selecting date ranges.

GitHub Issue Link (if applicable)

fixes #10929

Testing Plan

No additional testing is needed, as the problem is fairly simple and involves only a color change in a specific area.


Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@snyk-io
Copy link
Contributor

snyk-io bot commented Apr 28, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@lukasmasuch lukasmasuch added change:bugfix PR contains bug fix implementation impact:users PR changes affect end users labels May 1, 2025
@kmcgrady kmcgrady self-assigned this May 1, 2025
@kmcgrady kmcgrady added the security-assessment-completed Security assessment has been completed for PR label May 28, 2025
Copy link
Collaborator

@kmcgrady kmcgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Bernardo1008 . Apologies for the delay. I've been on vacation and just a bit overwhelmed. Appreciate your patience.

Things look overall well. Just had a question, and I think all you need to do is to is format it using prettier so that everything passes. Let me know if there's anything else I can do.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried not using the !important, and everything seems to work fine. Did you find a specific reason here that it is necessary?

@kmcgrady kmcgrady force-pushed the enhancement-10929 branch from afe4cef to b9890ce Compare June 9, 2025 05:41
Bernardo1008 and others added 2 commits June 9, 2025 09:01
Improved the DateInput component by applying custom hover styles for dates that fall within a selected range, specifically for the light theme. Enhances visual clarity and user experience when selecting date ranges.
@kmcgrady kmcgrady force-pushed the enhancement-10929 branch from b9890ce to 3847527 Compare June 9, 2025 16:01
@kmcgrady kmcgrady merged commit 8cd8e2a into streamlit:develop Jun 9, 2025
35 checks passed
@kmcgrady
Copy link
Collaborator

kmcgrady commented Jun 9, 2025

Thanks @Bernardo1008 I made the changes and verified it worked and merged. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:bugfix PR contains bug fix implementation impact:users PR changes affect end users security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

With date range selected in st.date_input, hovered dates should change color

3 participants