Remove set_page_config restrictions
#11286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
✅ PR preview is ready!
|
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
mayagbarnes
commented
May 8, 2025
| "🔥™🎉🚀🌌💣✨🌙🎆🎇💥🤩🤙🌛🤘⬆💡🤪🥂⚡💨🌠🎊🍿😛🔮🤟🌃🍃🍾💫▪🌴🎈🎬🌀🎄😝☔⛽🍂💃😎🍸🎨🥳☀😍🅱🌞😻🌟😜💦💅🦄😋😉👻🍁🤤👯🌻‼🌈👌🎃💛😚🔫🙌👽🍬🌅☁🍷👭☕🌚💁👅🥰🍜😌🎥🕺❕🧡☄💕🍻✅🌸🚬🤓🍹®☺💪😙☘🤠✊🤗🍵🤞😂💯😏📻🎂💗💜🌊❣🌝😘💆🤑🌿🦋😈⛄🚿😊🌹🥴😽💋😭🖤🙆👐⚪💟☃🙈🍭💻🥀🚗🤧🍝💎💓🤝💄💖🔞⁉⏰🕊🎧☠♥🌳🏾🙉⭐💊🍳🌎🙊💸❤🔪😆🌾✈📚💀🏠✌🏃🌵🚨💂🤫🤭😗😄🍒👏🙃🖖💞😅🎅🍄🆓👉💩🔊🤷⌚👸😇🚮💏👳🏽💘💿💉👠🎼🎶🎤👗❄🔐🎵🤒🍰👓🏄🌲🎮🙂📈🚙📍😵🗣❗🌺🙄👄🚘🥺🌍🏡♦💍🌱👑👙☑👾🍩🥶📣🏼🤣☯👵🍫➡🎀😃✋🍞🙇😹🙏👼🐝⚫🎁🍪🔨🌼👆👀😳🌏📖👃🎸👧💇🔒💙😞⛅🏻🍴😼🗿🍗♠🦁✔🤖☮🐢🐎💤😀🍺😁😴📺☹😲👍🎭💚🍆🍋🔵🏁🔴🔔🧐👰☎🏆🤡🐠📲🙋📌🐬✍🔑📱💰🐱💧🎓🍕👟🐣👫🍑😸🍦👁🆗🎯📢🚶🦅🐧💢🏀🚫💑🐟🌽🏊🍟💝💲🐍🍥🐸☝♣👊⚓❌🐯🏈📰🌧👿🐳💷🐺📞🆒🍀🤐🚲🍔👹🙍🌷🙎🐥💵🔝📸⚠❓🎩✂🍼😑⬇⚾🍎💔🐔⚽💭🏌🐷🍍✖🍇📝🍊🐙👋🤔🥊🗽🐑🐘🐰💐🐴♀🐦🍓✏👂🏴👇🆘😡🏉👩💌😺✝🐼🐒🐶👺🖕👬🍉🐻🐾⬅⏬▶👮🍌♂🔸👶🐮👪⛳🐐🎾🐕👴🐨🐊🔹©🎣👦👣👨👈💬⭕📹📷" | ||
| ) | ||
|
|
||
| # Also pick out some vanity emojis. |
Collaborator
Author
There was a problem hiding this comment.
Confirmed with Johannes to remove these
mayagbarnes
commented
May 8, 2025
| if ABOUT_KEY in lowercase_menu_items: | ||
| if lowercase_menu_items[ABOUT_KEY] is not None: | ||
| menu_items_proto.about_section_md = dedent(lowercase_menu_items[ABOUT_KEY]) | ||
| else: |
Collaborator
Author
There was a problem hiding this comment.
Needed to handle case where "About" markdown intially set and then updated to None, for consistent behavior with other menu_items fields.
Collaborator
There was a problem hiding this comment.
nit: it would be good to add that as a comment in the code as well
set_page_config restrictionsset_page_config restrictions
Contributor
📉 Frontend coverage change detectedThe frontend unit test (vitest) coverage has decreased by 0.0200%
✅ Coverage change is within normal range. |
lukasmasuch
approved these changes
May 9, 2025
| string report_a_bug_url = 3; | ||
| bool hide_report_a_bug = 4; | ||
| string about_section_md = 5; | ||
| bool clear_about_md = 6; |
Collaborator
There was a problem hiding this comment.
nit: maybe add a small comment in the proto what this flag does.
| if ABOUT_KEY in lowercase_menu_items: | ||
| if lowercase_menu_items[ABOUT_KEY] is not None: | ||
| menu_items_proto.about_section_md = dedent(lowercase_menu_items[ABOUT_KEY]) | ||
| else: |
Collaborator
There was a problem hiding this comment.
nit: it would be good to add that as a comment in the code as well
sfc-gh-lmasuch
approved these changes
May 10, 2025
mayagbarnes
added a commit
that referenced
this pull request
Jun 17, 2025
To better enable additive calls to `st.set_page_config` now that restrictions have been removed (#11286), make params `layout` & `initial_sidebar_state` default to `None` if not set so they inherit the behavior of the previous call. If there is no previous call (1st `st.set_page_config` call), these will be set by the FE to the defaults - values `"centered"` & `"auto"` respectively.
sfc-gh-mbarnes
pushed a commit
that referenced
this pull request
Jun 17, 2025
To better enable additive calls to `st.set_page_config` now that restrictions have been removed (#11286), make params `layout` & `initial_sidebar_state` default to `None` if not set so they inherit the behavior of the previous call. If there is no previous call (1st `st.set_page_config` call), these will be set by the FE to the defaults - values `"centered"` & `"auto"` respectively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR remove the two
st.set_page_configrestrictions:stcommand (with some exceptions)The properties are additive (if the first call sets a
page_titleand the second call sets apage_icon, the page now has both the provided title & icon).This also applies for
menu_items.GitHub Issue Link (if applicable)
Closes #4483
Closes #2216
Closes #9797
Closes #9038
Testing Plan