Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@lukasmasuch
Copy link
Collaborator

@lukasmasuch lukasmasuch commented May 24, 2025

Describe your changes

Fixes a segmentation fault crash that happens in some environments when editing dataframe index values with data editor. This seems be a bug with pandas or numpy and only happens when combined with a value from session state and only in some environments. An alternative way of updating index values via df.rename seems to work fine.

GitHub Issue Link (if applicable)

Testing Plan

  • Added a unit test covering the editing behaviour described in the bug.

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@snyk-io
Copy link
Contributor

snyk-io bot commented May 24, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@github-actions
Copy link
Contributor

github-actions bot commented May 24, 2025

✅ PR preview is ready!

Name Link
📦 Wheel file https://core-previews.s3-us-west-2.amazonaws.com/pr-11448/streamlit-1.45.1-py3-none-any.whl
🕹️ Preview app pr-11448.streamlit.app (☁️ Deploy here if not accessible)

@lukasmasuch lukasmasuch added security-assessment-completed Security assessment has been completed for PR change:bugfix PR contains bug fix implementation impact:users PR changes affect end users labels May 24, 2025
@lukasmasuch lukasmasuch marked this pull request as ready for review May 24, 2025 15:23
@lukasmasuch lukasmasuch merged commit 79fb20b into develop May 28, 2025
39 of 40 checks passed
@lukasmasuch lukasmasuch deleted the fix/crash-when-editing-df-index branch May 28, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:bugfix PR contains bug fix implementation impact:users PR changes affect end users security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Data editor does not correctly allow index editing

3 participants