Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Rename backend base url window variables to use __streamlit object #11481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vdonato merged 3 commits into from
May 30, 2025
Merged

Rename backend base url window variables to use __streamlit object #11481

vdonato merged 3 commits into from
May 30, 2025

Conversation

@vdonato
Copy link
Collaborator

@vdonato vdonato commented May 30, 2025 •
edited
Loading

Describe your changes

I didn't realize we already had a __streamlit object when adding __STREAMLIT_BACKEND_BASE_URL
and __STREAMLIT_HOST_CONFIG_BASE_URL. Given this already exists, we should use it to namespace
these window variables.

Testing Plan

  • Unit Tests (JS and/or Python)
    • JS unit tests adjusted

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@vdonato vdonato added security-assessment-completed Security assessment has been completed for PR change:feature PR contains new feature or enhancement implementation impact:users PR changes affect end users labels May 30, 2025
@snyk-io
Copy link
Contributor

snyk-io bot commented May 30, 2025 •
edited
Loading

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)

@github-actions
Copy link
Contributor

github-actions bot commented May 30, 2025 •
edited
Loading

✅ PR preview is ready!

Name Link
📦 Wheel file https://core-previews.s3-us-west-2.amazonaws.com/pr-11481/streamlit-1.45.1-py3-none-any.whl
🕹️ Preview app pr-11481.streamlit.app (☁️ Deploy here if not accessible)

lukasmasuch
lukasmasuch approved these changes May 30, 2025
View reviewed changes
Copy link
Collaborator

@lukasmasuch lukasmasuch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 needs a merge/rebase to get the type checks resolved.

@vdonato vdonato merged commit 765f923 into develop May 30, 2025
37 checks passed
@vdonato vdonato deleted the vdonato/rename-backend-variables branch May 30, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukasmasuch lukasmasuch lukasmasuch approved these changes

Assignees

No one assigned

Labels

change:feature PR contains new feature or enhancement implementation impact:users PR changes affect end users security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vdonato @lukasmasuch @sfc-gh-atoader