Update Source (Sans|Serif|Code) font versions to variable #11600
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
✅ PR preview is ready!
|
📉 Significant wheel size change detectedThe wheel file size has decreased by 1.70% (threshold: 0.25%)
Please verify this change is expected. |
sfc-gh-bnisco
left a comment
There was a problem hiding this comment.
I did not go through all of the snapshots given the volume of them, but I did review the CSS changes and left a comment inline. This is an exciting PR!
| @@ -18,172 +18,64 @@ | |||
|
|
|||
| @font-face { | |||
| font-family: "Source Code Pro"; | |||
| font-weight: 400; | |||
| font-weight: 100 900; | |||
| font-style: regular; | |||
There was a problem hiding this comment.
suggestion: I understand this code was already written before this PR, but I believe the expected value for this is font-style: normal; [MDN docs]. This comment applies to any font-faces that use font-style: regular; in this file.
There was a problem hiding this comment.
I was wondering about this, was looking around but didnt find any info on this being a replaced/legacy value - just curious if you encountered any context?
There was a problem hiding this comment.
I honestly think it is just a long-standing typo. I don't know of this being a valid value 🤷♂️
This fixes the preload in our `index.html` to point to the updated variable files Follow-up to PR updating individual Source Sans font weight files to variable file (#11600)
Describe your changes
Allow for full font-weight gradient using variable font files
Before: (note 400 used for 100-500, 600 for 600, then 700 for 700+)
After: (note 100-900 each apply)
GitHub Issue Link (if applicable)
Testing Plan