Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@lukasmasuch
Copy link
Collaborator

@lukasmasuch lukasmasuch commented Jun 12, 2025

Describe your changes

Adds support for setting custom font faces via the window.__streamlit LIGHT_THEME or DARK_THEME. This functionality is used by SiS.

GitHub Issue Link (if applicable)

Testing Plan

  • Added e2e test.

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@snyk-io
Copy link
Contributor

snyk-io bot commented Jun 12, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@github-actions
Copy link
Contributor

github-actions bot commented Jun 12, 2025

✅ PR preview is ready!

Name Link
📦 Wheel file https://core-previews.s3-us-west-2.amazonaws.com/pr-11628/streamlit-1.45.1-py3-none-any.whl
🕹️ Preview app pr-11628.streamlit.app (☁️ Deploy here if not accessible)

@lukasmasuch lukasmasuch added security-assessment-completed Security assessment has been completed for PR change:bugfix PR contains bug fix implementation impact:users PR changes affect end users labels Jun 12, 2025
@lukasmasuch lukasmasuch changed the title [WIP] Add support for font faces from window preamble Add support for font faces from window preamble Jun 13, 2025
@lukasmasuch lukasmasuch marked this pull request as ready for review June 13, 2025 00:07
@lukasmasuch lukasmasuch merged commit 077c6c1 into develop Jun 13, 2025
37 checks passed
@lukasmasuch lukasmasuch deleted the add-support-for-font-faces-via-window-preamble branch June 13, 2025 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:bugfix PR contains bug fix implementation impact:users PR changes affect end users security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support setting the font faces via the theme window variable

3 participants