-
Notifications
You must be signed in to change notification settings - Fork 4k
Update glide data grid to fix upstream issues #11677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
✅ PR preview is ready!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request updates the glide‑data‑grid package to version 6.0.4‑alpha15 to address upstream issues and improve compatibility with advanced theming. Key changes include a class name update in the DataFrame styled components, explicit theme settings for bubble metrics and header icon size, dependency upgrades in package.json, and corresponding adjustments in E2E tests for selection behavior and list column overlays.
Reviewed Changes
Copilot reviewed 7 out of 50 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/lib/src/components/widgets/DataFrame/styled-components.ts | Changed a class selector from "gdg-seveqep" to "gdg-search-bar" to align with upstream updates. |
| frontend/lib/src/components/widgets/DataFrame/hooks/useCustomTheme.ts | Added theme measurements (headerIconSize, bubbleHeight, bubblePadding, bubbleMargin) for improved theming. |
| frontend/lib/package.json | Upgraded glide‑data‑grid dependencies from alpha9 to alpha15. |
| e2e_playwright/st_dataframe_selections_test.py | Expanded tests to verify that clicking an already selected column unselects it. |
| e2e_playwright/st_dataframe_config_test.py | Introduced a new test for the list cell overlay in DataFrame. |
| e2e_playwright/st_dataframe_config.py | Updated test data for list columns to better reflect expected UI behavior. |
| NOTICES | Revised third‑party license notices and attributions for cleanup and accuracy. |
Comments suppressed due to low confidence (7)
frontend/lib/src/components/widgets/DataFrame/styled-components.ts:48
- The class name has been updated to 'gdg-search-bar', which likely aligns with upstream changes. Please ensure that all references and styles are updated accordingly.
"& .gdg-search-bar": {
e2e_playwright/st_dataframe_selections_test.py:162
- [nitpick] This test now verifies that clicking an already selected column unselects it. Confirm that this behavior aligns with the updated grid selection logic.
select_column(canvas, 2)
e2e_playwright/st_dataframe_config_test.py:141
- [nitpick] The new test for the list cell overlay verifies the visual correctness when interacting with list columns. Ensure that both the interactivity and the snapshot match the intended design.
def test_list_cell_overlay(themed_app: Page, assert_snapshot: ImageCompareFunction):
e2e_playwright/st_dataframe_config.py:431
- [nitpick] The test data for 'col_1' has been updated to use an array of strings for list column validation. Confirm that this change accurately reflects the intended UI behavior for list columns.
"col_1": [
NOTICES:5
- [nitpick] The NOTICES file has been significantly updated to reflect current attributions. Please ensure that all required third-party license notices remain accurate and complete.
The following software may be included in this product: @babel/code-frame, @babel/generator, @babel/helper-module-imports, @babel/helper-string-parser, @babel/helper-validator-identifier, @babel/runtime, @babel/template, @babel/traverse, @babel/types. A copy of the source code may be downloaded from https://github.com/babel/babel.git (@babel/code-frame), https://github.com/babel/babel.git (@babel/generator), https://github.com/babel/babel.git (@babel/helper-module-imports), https://github.com/babel/babel.git (@babel/helper-string-parser), https://github.com/babel/babel.git (@babel/helper-validator-identifier), https://github.com/babel/babel.git (@babel/runtime), https://github.com/babel/babel.git (@babel/template), https://github.com/babel/babel.git (@babel/traverse), https://github.com/babel/babel.git (@babel/types). This software contains the following license and notice below:
frontend/lib/src/components/widgets/DataFrame/hooks/useCustomTheme.ts:85
- The addition of headerIconSize along with the new bubble metrics (bubbleHeight, bubblePadding, bubbleMargin) improves theme consistency. Please confirm that these values align with design specifications.
headerIconSize: Math.round(convertRemToPx("1.125rem")),
frontend/lib/package.json:52
- The dependency versions for glide‑data‑grid packages have been updated to alpha15. Verify through E2E tests that the updated versions are fully compatible with existing integrations.
"@glideapps/glide-data-grid": "6.0.4-alpha15",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The scroll bars seem to be only appearing on the webkit snapshots. Not sure if there is much we can do about them, but a bit worried they will lead to flakiness.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, this is related to a recent change to our scrollbars. I'm planning to take another look at our safari scrollbars soon.
sfc-gh-lwilby
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Describe your changes
Updates glide-data-grid to the latest version, which also fixes a couple of upstream issues and improves compatibility with our advanced theming.
GitHub Issue Link (if applicable)
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.