Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@lukasmasuch
Copy link
Collaborator

@lukasmasuch lukasmasuch commented Jun 17, 2025

Describe your changes

Updates glide-data-grid to the latest version, which also fixes a couple of upstream issues and improves compatibility with our advanced theming.

GitHub Issue Link (if applicable)

Testing Plan

  • Existing tests should cover this well.

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@snyk-io
Copy link
Contributor

snyk-io bot commented Jun 17, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2025

✅ PR preview is ready!

Name Link
📦 Wheel file https://core-previews.s3-us-west-2.amazonaws.com/pr-11677/streamlit-1.46.1-py3-none-any.whl
🕹️ Preview app pr-11677.streamlit.app (☁️ Deploy here if not accessible)

@lukasmasuch lukasmasuch changed the title Update glide data grid [WIP]U pdate glide data grid Jun 17, 2025
@lukasmasuch lukasmasuch changed the title [WIP]U pdate glide data grid [WIP] Update glide data grid Jun 17, 2025
@sfc-gh-lmasuch sfc-gh-lmasuch added security-assessment-completed Security assessment has been completed for PR change:other PR contains other type of change impact:internal PR changes only affect internal code labels Jun 17, 2025
@sfc-gh-lmasuch sfc-gh-lmasuch added change:bugfix PR contains bug fix implementation impact:users PR changes affect end users and removed change:other PR contains other type of change impact:internal PR changes only affect internal code labels Jun 26, 2025
@sfc-gh-lmasuch sfc-gh-lmasuch changed the title [WIP] Update glide data grid [WIP] Update glide data grid to fix upstream issues Jun 26, 2025
@sfc-gh-lmasuch sfc-gh-lmasuch requested a review from Copilot June 26, 2025 19:41
@sfc-gh-lmasuch sfc-gh-lmasuch changed the title [WIP] Update glide data grid to fix upstream issues Update glide data grid to fix upstream issues Jun 26, 2025
@sfc-gh-lmasuch sfc-gh-lmasuch marked this pull request as ready for review June 26, 2025 19:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the glide‑data‑grid package to version 6.0.4‑alpha15 to address upstream issues and improve compatibility with advanced theming. Key changes include a class name update in the DataFrame styled components, explicit theme settings for bubble metrics and header icon size, dependency upgrades in package.json, and corresponding adjustments in E2E tests for selection behavior and list column overlays.

Reviewed Changes

Copilot reviewed 7 out of 50 changed files in this pull request and generated no comments.

Show a summary per file
File Description
frontend/lib/src/components/widgets/DataFrame/styled-components.ts Changed a class selector from "gdg-seveqep" to "gdg-search-bar" to align with upstream updates.
frontend/lib/src/components/widgets/DataFrame/hooks/useCustomTheme.ts Added theme measurements (headerIconSize, bubbleHeight, bubblePadding, bubbleMargin) for improved theming.
frontend/lib/package.json Upgraded glide‑data‑grid dependencies from alpha9 to alpha15.
e2e_playwright/st_dataframe_selections_test.py Expanded tests to verify that clicking an already selected column unselects it.
e2e_playwright/st_dataframe_config_test.py Introduced a new test for the list cell overlay in DataFrame.
e2e_playwright/st_dataframe_config.py Updated test data for list columns to better reflect expected UI behavior.
NOTICES Revised third‑party license notices and attributions for cleanup and accuracy.
Comments suppressed due to low confidence (7)

frontend/lib/src/components/widgets/DataFrame/styled-components.ts:48

  • The class name has been updated to 'gdg-search-bar', which likely aligns with upstream changes. Please ensure that all references and styles are updated accordingly.
      "& .gdg-search-bar": {

e2e_playwright/st_dataframe_selections_test.py:162

  • [nitpick] This test now verifies that clicking an already selected column unselects it. Confirm that this behavior aligns with the updated grid selection logic.
    select_column(canvas, 2)

e2e_playwright/st_dataframe_config_test.py:141

  • [nitpick] The new test for the list cell overlay verifies the visual correctness when interacting with list columns. Ensure that both the interactivity and the snapshot match the intended design.
def test_list_cell_overlay(themed_app: Page, assert_snapshot: ImageCompareFunction):

e2e_playwright/st_dataframe_config.py:431

  • [nitpick] The test data for 'col_1' has been updated to use an array of strings for list column validation. Confirm that this change accurately reflects the intended UI behavior for list columns.
            "col_1": [

NOTICES:5

  • [nitpick] The NOTICES file has been significantly updated to reflect current attributions. Please ensure that all required third-party license notices remain accurate and complete.
The following software may be included in this product: @babel/code-frame, @babel/generator, @babel/helper-module-imports, @babel/helper-string-parser, @babel/helper-validator-identifier, @babel/runtime, @babel/template, @babel/traverse, @babel/types. A copy of the source code may be downloaded from https://github.com/babel/babel.git (@babel/code-frame), https://github.com/babel/babel.git (@babel/generator), https://github.com/babel/babel.git (@babel/helper-module-imports), https://github.com/babel/babel.git (@babel/helper-string-parser), https://github.com/babel/babel.git (@babel/helper-validator-identifier), https://github.com/babel/babel.git (@babel/runtime), https://github.com/babel/babel.git (@babel/template), https://github.com/babel/babel.git (@babel/traverse), https://github.com/babel/babel.git (@babel/types). This software contains the following license and notice below:

frontend/lib/src/components/widgets/DataFrame/hooks/useCustomTheme.ts:85

  • The addition of headerIconSize along with the new bubble metrics (bubbleHeight, bubblePadding, bubbleMargin) improves theme consistency. Please confirm that these values align with design specifications.
      headerIconSize: Math.round(convertRemToPx("1.125rem")),

frontend/lib/package.json:52

  • The dependency versions for glide‑data‑grid packages have been updated to alpha15. Verify through E2E tests that the updated versions are fully compatible with existing integrations.
    "@glideapps/glide-data-grid": "6.0.4-alpha15",

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scroll bars seem to be only appearing on the webkit snapshots. Not sure if there is much we can do about them, but a bit worried they will lead to flakiness.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this is related to a recent change to our scrollbars. I'm planning to take another look at our safari scrollbars soon.

Copy link
Collaborator

@sfc-gh-lwilby sfc-gh-lwilby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasmasuch lukasmasuch merged commit cf57deb into develop Jul 2, 2025
38 checks passed
@lukasmasuch lukasmasuch deleted the update-glide-data-grid branch July 2, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:bugfix PR contains bug fix implementation impact:users PR changes affect end users security-assessment-completed Security assessment has been completed for PR

Projects

None yet

4 participants