Fixed timer bug #11756
Merged
Fixed timer bug #11756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Contributor
✅ PR preview is ready!
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a timer bug by switching from an interval-based timer to one that computes elapsed time using the system clock. Key changes include:
- Adding a useRef hook to record the initial start time.
- Updating the timer calculation to rely on system time instead of incremental state updates.
- Enhancing tests in the Spinner component to verify the new timer behavior.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| frontend/lib/src/components/elements/Spinner/Spinner.tsx | Updated timer logic to compute elapsed time using Date.now() and useRef |
| frontend/lib/src/components/elements/Spinner/Spinner.test.tsx | Added tests using fake timers to verify timer updates based on system time |
Comments suppressed due to low confidence (1)
frontend/lib/src/components/elements/Spinner/Spinner.tsx:40
- [nitpick] Consider renaming 'startTimeRef' to 'initialTimeRef' to more clearly indicate that it stores the time when the component mounts.
const startTimeRef = useRef<number | null>(null)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fixes #11720 where on moving away from current window, the timer pauses. Now we use system time to compare and update timer accordingly instead of using set interval.
GitHub Issue Link (if applicable)
#11720
Testing Plan
Yes, done by me.
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.