Ensure narrow currency symbol is used for formatting #11895
Merged
+21
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Contributor
✅ PR preview is ready!
|
| return formatIntlNumberWithLocales(value, { | ||
| style: "currency", | ||
| currency: "EUR", | ||
| currencyDisplay: "narrowSymbol", |
Collaborator
There was a problem hiding this comment.
question: Is it expected that this change did not yield an e2e snapshot change?
Collaborator
Author
There was a problem hiding this comment.
The narrow symbol is already used in our test cases. If this is not set, I think it depends on the locale if it shows a narrow or full symbol for a specific currency.
Collaborator
Author
There was a problem hiding this comment.
I added a unit test. If narrowSymbol wouldn't be set for "pt-BR", the yen would be shown with the wide symbol: JP¥ 10
…rency-symbol-number-formatting
sfc-gh-bnisco
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
When applying currency formatting via number or progress column, we always want to show the narrow symbol for
dollar,euro, andyen.Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.