Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use dvh instead of vh to support dynamic changing of height. #11896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sfc-gh-bnisco merged 1 commit into from
Jul 9, 2025
Merged

Use dvh instead of vh to support dynamic changing of height. #11896

sfc-gh-bnisco merged 1 commit into from
Jul 9, 2025

Conversation

@sfc-gh-lwilby
Copy link
Collaborator

@sfc-gh-lwilby sfc-gh-lwilby commented Jul 9, 2025 •
edited by sfc-gh-lmasuch
Loading

Describe your changes

GitHub Issue Link (if applicable)

Closes #11722
Closes #11891

Testing Plan

  • Existing tests.

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@snyk-io
Copy link
Contributor

snyk-io bot commented Jul 9, 2025 •
edited
Loading

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025 •
edited
Loading

✅ PR preview is ready!

Name Link
📦 Wheel file https://core-previews.s3-us-west-2.amazonaws.com/pr-11896/streamlit-1.46.1-py3-none-any.whl
🕹️ Preview app pr-11896.streamlit.app (☁️ Deploy here if not accessible)

@sfc-gh-lwilby sfc-gh-lwilby changed the title try dvh Use dvh instead of vh to support dynamic changing of height. Jul 9, 2025
@sfc-gh-lwilby sfc-gh-lwilby added security-assessment-completed Security assessment has been completed for PR change:bugfix PR contains bug fix implementation impact:users PR changes affect end users labels Jul 9, 2025
@sfc-gh-lwilby sfc-gh-lwilby marked this pull request as ready for review July 9, 2025 20:44
@sfc-gh-bnisco sfc-gh-bnisco merged commit c39186c into develop Jul 9, 2025
39 of 40 checks passed
@sfc-gh-bnisco sfc-gh-bnisco deleted the fix/use-dynamic-height-for-mobile branch July 9, 2025 22:41
@sfc-gh-lwilby sfc-gh-lwilby mentioned this pull request Jul 15, 2025
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfc-gh-bnisco sfc-gh-bnisco sfc-gh-bnisco approved these changes

Assignees

No one assigned

Labels

change:bugfix PR contains bug fix implementation impact:users PR changes affect end users security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Milestone

No milestone

3 participants

@sfc-gh-lwilby @sfc-gh-bnisco