Fix confusing no running event loop logs
#12008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Contributor
✅ PR preview is ready!
|
lukasmasuch
commented
Jul 22, 2025
| task = asyncio.create_task(main(), name="bootstrap.run_server") | ||
| # Store task reference on the server to keep it alive | ||
| # This prevents the task from being garbage collected | ||
| server._bootstrap_task = task |
Collaborator
Author
There was a problem hiding this comment.
Our linting recommends to keep a task reference to prevent this from being garbage collected.
sfc-gh-nbellante
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This improves our bootstrap logic and prevents the confusing
RuntimeError: no running event loopmessage from being displayed on unrelated errors. In the current state, ifasyncio.run(main())throws an uncaught exception, it will always show as:since the exception is thrown within the
except RuntimeErrorblock. This is confusing since the RuntimeError is expected.Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.