Add support for rerunning app when dialog gets dismissed #12034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Contributor
✅ PR preview is ready!
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements support for rerunning the app when a dialog gets dismissed by the user. It adds an on_dismiss parameter to the dialog decorator that can be set to "rerun" to trigger app reruns or to a callback function for custom dismissal handling.
- Adds
on_dismissparameter to dialog decorator and internal dialog implementation - Integrates dialog dismissal with Streamlit's widget system for state management
- Extends frontend dialog component to send widget events on dismissal
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| proto/streamlit/proto/Block.proto | Adds id field to Dialog message for widget registration |
| lib/streamlit/elements/lib/dialog.py | Implements on_dismiss functionality with widget registration |
| lib/streamlit/elements/layouts.py | Passes on_dismiss parameter to dialog creation |
| lib/streamlit/elements/dialog_decorator.py | Adds on_dismiss parameter to dialog decorator API |
| frontend/lib/src/components/elements/Dialog/Dialog.tsx | Implements frontend dismissal handling with widget events |
| frontend/lib/src/components/core/Block/Block.tsx | Passes widget manager and fragment ID to Dialog component |
| lib/tests/streamlit/elements/layouts_test.py | Adds unit tests for on_dismiss functionality |
| frontend/lib/src/components/elements/Dialog/Dialog.test.tsx | Adds frontend tests for dismissal behavior |
| e2e_playwright/st_dialog.py | Adds test app for on_dismiss functionality |
| e2e_playwright/st_dialog_test.py | Adds end-to-end tests for dialog dismissal |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Bugbot free trial expires on July 29, 2025
Learn more in the Cursor dashboard.
sfc-gh-bnisco
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Implements support for rerunning the app when the dialog gets dismissed by the user. This can be activated via
on_dismiss="rerun" or callback.GitHub Issue Link (if applicable)
st.dialogby clicking on X or pressing Escape #8507Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.