Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@lukasmasuch
Copy link
Collaborator

@lukasmasuch lukasmasuch commented Jul 28, 2025

Describe your changes

Fixes a deprecation warning with vega charts:

image

Testing Plan

  • Existing tests should cover this well since its running with the newest and oldest supported altair version in CI.

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@snyk-io
Copy link
Contributor

snyk-io bot commented Jul 28, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@github-actions
Copy link
Contributor

github-actions bot commented Jul 28, 2025

✅ PR preview is ready!

Name Link
📦 Wheel file https://core-previews.s3-us-west-2.amazonaws.com/pr-12050/streamlit-1.47.1-py3-none-any.whl
🕹️ Preview app pr-12050.streamlit.app (☁️ Deploy here if not accessible)

@lukasmasuch lukasmasuch marked this pull request as ready for review July 28, 2025 13:57
@lukasmasuch lukasmasuch added security-assessment-completed Security assessment has been completed for PR change:other PR contains other type of change impact:users PR changes affect end users labels Jul 28, 2025
@lukasmasuch lukasmasuch requested a review from Copilot July 28, 2025 13:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a deprecation warning in Altair by updating the theme access pattern. The alt.themes attribute was deprecated in Altair 5.5.0 in favor of alt.theme.

Key Changes:

  • Conditional theme access based on Altair version to maintain backward compatibility
  • Updated the theme enabling logic to use the appropriate API

@lukasmasuch lukasmasuch merged commit ed923aa into develop Jul 28, 2025
40 of 41 checks passed
@lukasmasuch lukasmasuch deleted the fix/vega-themes-deprecation branch July 28, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:other PR contains other type of change impact:users PR changes affect end users security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants