[Fix] st.toast handles custom theming
#12160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Contributor
✅ PR preview is ready!
|
st.toast handles custom themingst.toast handles custom theming
| # Reload to apply the theme | ||
| app.reload() | ||
| wait_for_app_loaded(app) | ||
| app.wait_for_timeout(250) |
Contributor
There was a problem hiding this comment.
The Streamlit E2E Tests guide explicitly prohibits using wait_for_timeout and recommends the wait_until utility instead. Replace app.wait_for_timeout(250) with a reliable condition-based wait using wait_until rather than an arbitrary timeout.
Spotted by Diamond (based on custom rule: E2E Playwright Tests)
Is this helpful? React 👍 or 👎 to let us know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Ensure
st.toastutilizes background color from custom theme configuration by removing explicit color values.Note this does change the toast background color for default dark theme.
Before:
After:
GitHub Issue Link (if applicable)
Closes #11951
Testing Plan