Add yellow to text/background/badge/divider color options
#12201
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
✅ PR preview is ready!
|
1ce2b14 to
dbcb9ba
Compare
There was a problem hiding this comment.
custom_themed_app & sidebar_custom_theme snapshot updates result of rainbow gradient change in sidebar
| theme.colors[lightTheme ? "yellow80" : "yellow70"], | ||
| 0.9 | ||
| ), |
There was a problem hiding this comment.
The yellowbg background color uses a hardcoded transparency value of 0.9 instead of the conditional transparency pattern used by all other background colors. This breaks visual consistency between light and dark themes. Should be: lightTheme ? 0.9 : 0.7 to match the pattern used by redbg, bluebg, greenbg, and violetbg.
| theme.colors[lightTheme ? "yellow80" : "yellow70"], | |
| 0.9 | |
| ), | |
| theme.colors[lightTheme ? "yellow80" : "yellow70"], | |
| lightTheme ? 0.9 : 0.7 | |
| ), |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
There was a problem hiding this comment.
Note: this is intentionally different - the other colors will be reconciled with upcoming color config changes
Describe your changes
Advanced Theming: add additional color option -
"yellow"for the following::yellow[text here]):yellow-background[text here]):yellow-badge[text here]orst.badge("Badge", color="yellow"))st.header("Header", divider="yellow")orst.subheader("Subheader", divider="yellow"))Testing Plan