Make crossorigin property configurable for st.logo #12226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Contributor
✅ PR preview is ready!
|
lukasmasuch
approved these changes
Aug 15, 2025
Comment on lines
+72
to
+75
| const crossOrigin = getCrossOriginAttribute( | ||
| libConfig.resourceCrossOriginMode, | ||
| displayImage | ||
| ) |
Collaborator
There was a problem hiding this comment.
nit: isn't useCrossOriginAttribute also usable here?
Collaborator
Author
There was a problem hiding this comment.
yep, I used that first but since hooks have to be called unconditionally, it has to be above the if check and the useCrossOriginAttribute hook takes the URL, so the displayImage block would have to be moved up as well and the if condition changed which made it a little bit messier, so I switched to this option here to keep the rest the same
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Follow-up of #11948 and #12087
Allows configuring the
crossoriginattribute also for the img element used by thest.logocommand.GitHub Issue Link (if applicable)
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.