Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@plumol
Copy link
Contributor

@plumol plumol commented Aug 15, 2025

Describe your changes

Fixes #12230 by preventing underlying column menu from opening.

Doesn't affect opening other column menus that are not underneath- the visibility menu closes when clicking outside, which enables the below segment to run without issues.

GitHub Issue Link (if applicable)

Testing Plan

  • Not sure how to directly test the interaction through the code because it relies on a specific mouse location, open to suggestions and comments

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@snyk-io
Copy link
Contributor

snyk-io bot commented Aug 15, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@plumol plumol changed the title Fix: prevents underlying column menu from opening when column visibility menu is open Fix: prevents underlying column menu from opening when column visibility menu is open for st.dataframe Aug 15, 2025
@sfc-gh-bnisco sfc-gh-bnisco added change:bugfix PR contains bug fix implementation impact:users PR changes affect end users labels Aug 15, 2025
@lukasmasuch lukasmasuch added the security-assessment-completed Security assessment has been completed for PR label Aug 15, 2025
Copy link
Collaborator

@lukasmasuch lukasmasuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I added a comment to the code with some context.

@lukasmasuch lukasmasuch enabled auto-merge (squash) August 15, 2025 21:23
@lukasmasuch lukasmasuch merged commit 4932848 into streamlit:develop Aug 15, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:bugfix PR contains bug fix implementation impact:users PR changes affect end users security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clicking on column visibility menu in st.dataframe opens column menu behind it

3 participants