Apply radii from theme to CheckboxColumn
#12263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Contributor
✅ PR preview is ready!
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR applies theme-based border radius styling to the CheckboxColumn component in the DataFrame widget. The change ensures that checkbox elements follow the application's theme configuration for consistent visual appearance.
Key Changes:
- Modified CheckboxColumn function to accept a theme parameter and apply rounding radius from theme configuration
- Updated all test cases to pass the required theme parameter
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
frontend/lib/src/components/widgets/DataFrame/columns/CheckboxColumn.ts |
Added theme parameter and themeOverride configuration to apply rounded corners based on theme radii |
frontend/lib/src/components/widgets/DataFrame/columns/CheckboxColumn.test.ts |
Updated all test calls to include theme parameter and added test for themeOverride functionality |
CheckboxColumn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Apply the radii configured in the theme to the
CheckboxColumn.Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.