Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix file watcher issue with common path check #12741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lukasmasuch merged 2 commits into from
Oct 15, 2025
Merged

Fix file watcher issue with common path check #12741

lukasmasuch merged 2 commits into from
Oct 15, 2025

Conversation

@lukasmasuch
Copy link
Collaborator

@lukasmasuch lukasmasuch commented Oct 10, 2025 •
edited
Loading

Describe your changes

Improves error handling to prevent issues with commonpath operation on windows during file watching.

GitHub Issue Link (if applicable)

Testing Plan

  • Added unit test.

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@snyk-io
Copy link
Contributor

snyk-io bot commented Oct 10, 2025 •
edited
Loading

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2025 •
edited
Loading

✅ PR preview is ready!

Name Link
📦 Wheel file https://core-previews.s3-us-west-2.amazonaws.com/pr-12741/streamlit-1.50.0-py3-none-any.whl
📦 @streamlit/component-v2-lib Download from artifacts
🕹️ Preview app pr-12741.streamlit.app (☁️ Deploy here if not accessible)

@sfc-gh-lmasuch sfc-gh-lmasuch added security-assessment-completed Security assessment has been completed for PR impact:internal PR changes only affect internal code change:bugfix PR contains bug fix implementation impact:users PR changes affect end users and removed impact:internal PR changes only affect internal code labels Oct 10, 2025
@sfc-gh-lmasuch sfc-gh-lmasuch marked this pull request as ready for review October 10, 2025 11:40
sfc-gh-lwilby
sfc-gh-lwilby approved these changes Oct 14, 2025
View reviewed changes
Copy link
Collaborator

@sfc-gh-lwilby sfc-gh-lwilby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The user did reply saying their files are not on different drives, so there may be a different cause for their issue. However, this seems like a good improvement anyways.

@lukasmasuch lukasmasuch merged commit a8e49a8 into develop Oct 15, 2025
38 checks passed
@lukasmasuch lukasmasuch deleted the fix/common-path-windows-issue branch October 15, 2025 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@sfc-gh-lwilby sfc-gh-lwilby sfc-gh-lwilby approved these changes

Assignees

No one assigned

Labels

change:bugfix PR contains bug fix implementation impact:users PR changes affect end users security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ValueError: Paths don't have the same drive

4 participants

@lukasmasuch @sfc-gh-lwilby @sfc-gh-lmasuch