Implement transient spinners #12826

kmcgrady · 2025-10-19T20:35:59Z

Describe your changes

Implemented a new transient element system to improve the spinner component. This change:

Adds a TransientNode to the render tree to handle temporary UI elements
Refactors the spinner implementation to use the new transient system instead of empty placeholders
Ensures spinners are properly ordered and cleaned up when their context exits
Moves spinner from a standalone import to a mixin on DeltaGenerator

This approach provides a more robust way to handle temporary UI elements like spinners, preventing stale elements and ensuring proper cleanup.

GitHub Issue Link (if applicable)

Closes Old AI response duplicating (faded) #9239
Closes Page Reload on Cache Miss #10199

Testing Plan

Unit Tests: Added comprehensive tests for the new TransientNode and updated AppRoot functionality in AppRoot.test.ts
Updated existing spinner tests to work with the new transient implementation
Manual testing of spinner behavior in various contexts (regular, nested, caching)

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

snyk-io · 2025-10-19T20:36:08Z

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues
✅	Licenses	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

github-actions · 2025-10-19T20:36:13Z

✅ PR preview is ready!

Name	Link
📦 Wheel file	https://core-previews.s3-us-west-2.amazonaws.com/pr-12826/streamlit-1.52.0-py3-none-any.whl
📦 `@streamlit/component-v2-lib`	Download from artifacts
🕹️ Preview app	pr-12826.streamlit.app (☁️ Deploy here if not accessible)

kmcgrady · 2025-10-19T20:36:29Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2025-10-19T20:59:19Z

📈 Frontend coverage change detected

The frontend unit test (vitest) coverage has increased by 0.0200%

Current PR: 85.9300% (12445 lines, 1751 missed)
Latest develop: 85.9100% (12421 lines, 1750 missed)

✅ Coverage change is within normal range.

📊 View detailed coverage comparison

lib/tests/streamlit/write_test.py

lib/streamlit/cursor.py

lib/streamlit/elements/spinner.py

Copilot

Pull request overview

Copilot reviewed 46 out of 46 changed files in this pull request and generated 15 comments.

lib/streamlit/elements/spinner.py

lib/streamlit/cursor.py

frontend/lib/src/render-tree/visitors/SetNodeByDeltaPathVisitor.ts

lib/tests/streamlit/write_test.py

lib/streamlit/cursor.py

lib/streamlit/delta_generator.py

e2e_playwright/st_spinner.py

lib/tests/streamlit/runtime/caching/cache_resource_api_test.py

lib/tests/streamlit/write_test.py

proto/streamlit/proto/Delta.proto

lib/streamlit/delta_generator.py

lukasmasuch

LGTM 👍

This was referenced Oct 19, 2025

Break up AppNode into separate files #12809

Merged

Add Visitor pattern to AppNodes with a Debug Visitor #12810

Merged

kmcgrady added the security-assessment-completed Security assessment has been completed for PR label Oct 19, 2025 — with Graphite App

This was referenced Oct 19, 2025

Migrate getElements to the ElementsSetVisitor #12811

Merged

Migrate getIn to GetNodeByDeltaPathVisitor #12812

Merged

Migrate filterMainScriptElements to FilterMainScriptElementsVisitor #12813

Merged

kmcgrady added the change:bugfix PR contains bug fix implementation label Oct 19, 2025 — with Graphite App

kmcgrady added the impact:users PR changes affect end users label Oct 19, 2025 — with Graphite App

kmcgrady mentioned this pull request Oct 19, 2025

Implement visitTransientNode on RenderNodeVisitor #12825

Merged

kmcgrady force-pushed the 10-19-implement_transient_spinners branch from 18c4f1f to 8e86cca Compare October 19, 2025 20:44

kmcgrady changed the base branch from 10-19-implement_visittransientnode_on_rendernodevisitor to graphite-base/12826 October 20, 2025 14:42

kmcgrady force-pushed the 10-19-implement_transient_spinners branch from 8e86cca to 9158c17 Compare October 20, 2025 14:42

kmcgrady changed the base branch from graphite-base/12826 to 10-20-migrate_spinner_to_a_mixin October 20, 2025 14:42

kmcgrady mentioned this pull request Oct 20, 2025

Migrate spinner to a Mixin #12829

Merged

kmcgrady force-pushed the 10-19-implement_transient_spinners branch 4 times, most recently from d9b33ab to dfcd3bc Compare October 24, 2025 15:05

kmcgrady force-pushed the 10-20-migrate_spinner_to_a_mixin branch from 1af2b5d to cd702ac Compare October 24, 2025 15:05

kmcgrady force-pushed the 10-19-implement_transient_spinners branch from bc67db4 to ff0535a Compare December 2, 2025 02:06

kmcgrady changed the base branch from graphite-base/12826 to develop December 2, 2025 02:07

kmcgrady force-pushed the 10-19-implement_transient_spinners branch from ff0535a to efb44c4 Compare December 4, 2025 03:23

github-code-quality bot found potential problems Dec 4, 2025

View reviewed changes

lib/tests/streamlit/write_test.py Fixed Show fixed Hide fixed

lib/tests/streamlit/write_test.py Fixed Show fixed Hide fixed

graphite-app bot reviewed Dec 4, 2025

View reviewed changes

lib/streamlit/cursor.py Show resolved Hide resolved

kmcgrady force-pushed the 10-19-implement_transient_spinners branch 2 times, most recently from e1c6670 to 3fea9c0 Compare December 4, 2025 15:21

graphite-app bot reviewed Dec 4, 2025

View reviewed changes

lib/streamlit/elements/spinner.py Show resolved Hide resolved

kmcgrady force-pushed the 10-19-implement_transient_spinners branch from 3fea9c0 to 7e8e837 Compare December 4, 2025 15:30

sfc-gh-kmcgrady added the flaky-verify If applied to PR will run flaky test verification workflow label Dec 4, 2025

github-actions bot removed the flaky-verify If applied to PR will run flaky test verification workflow label Dec 4, 2025

kmcgrady force-pushed the 10-19-implement_transient_spinners branch 2 times, most recently from aa8bf80 to 70b1351 Compare December 4, 2025 17:12

lukasmasuch requested a review from Copilot December 8, 2025 14:50

Copilot started reviewing on behalf of lukasmasuch December 8, 2025 14:51 View session

Copilot AI reviewed Dec 8, 2025

View reviewed changes

kmcgrady force-pushed the 10-19-implement_transient_spinners branch 3 times, most recently from 3ec60af to 9484285 Compare December 8, 2025 16:18

graphite-app bot reviewed Dec 8, 2025

View reviewed changes

lib/tests/streamlit/write_test.py Outdated Show resolved Hide resolved

kmcgrady force-pushed the 10-19-implement_transient_spinners branch from 9484285 to df0d3ed Compare December 8, 2025 16:25

lukasmasuch reviewed Dec 8, 2025

View reviewed changes

proto/streamlit/proto/Delta.proto Show resolved Hide resolved

lib/streamlit/delta_generator.py Show resolved Hide resolved

lukasmasuch approved these changes Dec 8, 2025

View reviewed changes

kmcgrady force-pushed the 10-19-implement_transient_spinners branch from df0d3ed to e6b4f56 Compare December 8, 2025 17:50

Implement transient spinners

75bb6e7

kmcgrady force-pushed the 10-19-implement_transient_spinners branch from e6b4f56 to 75bb6e7 Compare December 8, 2025 17:52

sfc-gh-lmasuch approved these changes Dec 8, 2025

View reviewed changes

kmcgrady merged commit 349d1f1 into develop Dec 8, 2025
44 checks passed

kmcgrady deleted the 10-19-implement_transient_spinners branch December 8, 2025 18:10

github-actions bot mentioned this pull request Jan 21, 2026

App goes blank when creating element (st.tabs, st.columns) within a container in a spinner context #13658

Closed

4 tasks

Implement transient spinners #12826

Implement transient spinners #12826

Uh oh!

Conversation

kmcgrady commented Oct 19, 2025 • edited by lukasmasuch Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your changes

GitHub Issue Link (if applicable)

Testing Plan

Uh oh!

snyk-io bot commented Oct 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Snyk checks have passed. No issues have been found so far.

Uh oh!

github-actions bot commented Oct 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ PR preview is ready!

Uh oh!

kmcgrady commented Oct 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📈 Frontend coverage change detected

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lukasmasuch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kmcgrady commented Oct 19, 2025 •

edited by lukasmasuch

Loading

snyk-io bot commented Oct 19, 2025 •

edited

Loading

github-actions bot commented Oct 19, 2025 •

edited

Loading

kmcgrady commented Oct 19, 2025 •

edited

Loading

github-actions bot commented Oct 19, 2025 •

edited

Loading