[fix] Reclassify Auth Callback Error -> Warning #13127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
✅ PR preview is ready!
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves error handling for OAuth callback scenarios by reclassifying a log message from error to warning severity. The change addresses situations where OAuth callbacks are received without a valid provider, which typically occurs from stale or replayed requests (e.g., browser back/forward navigation) rather than genuine errors.
Key Changes
- Changed log severity from
errortowarningfor missing OAuth provider scenarios - Enhanced the log message to provide helpful context about the likely cause (stale/replayed callbacks)
- Added a reference comment linking to the related GitHub issue #13101
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Improved the error message when a provider is missing for an OAuth callback. Changed the log level from
errortowarningand added more context to the message, explaining that this often indicates a stale or replayed callback (e.g., from browser back/forward navigation).GitHub Issue Link (if applicable)
Fixes #13101
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.