-
Notifications
You must be signed in to change notification settings - Fork 4k
Add gaps and sizes for xxsmall, xsmall, xlarge, xxlarge in st.container/columns/space #13345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
fe537ca
Add xxsmall, xsmall, xlarge, and xxlarge to gap in st.container and s…
sfc-gh-tteixeira eaa962c
Add new sizing st.space as well
sfc-gh-tteixeira 8118e07
Merge remote-tracking branch 'origin/develop' into xsmall
sfc-gh-tteixeira 9ab908c
Add missing gap tests.
sfc-gh-tteixeira 5a47b08
Fix tests
sfc-gh-tteixeira 653f978
Fix types some more
sfc-gh-tteixeira 226a829
Fix typing (again)
sfc-gh-tteixeira 4c617f7
Update screenshots
sfc-gh-tteixeira 88a740d
Merge remote-tracking branch 'origin/develop' into xsmall
sfc-gh-tteixeira fce8bfd
Add st.space e2e tests
sfc-gh-tteixeira 736680f
Merge remote-tracking branch 'origin/develop' into xsmall
sfc-gh-tteixeira afd813e
Fix typing in st_space_test
sfc-gh-tteixeira 588cfe4
Fix tests
sfc-gh-tteixeira 236145b
Add snapshots
sfc-gh-tteixeira 81f0607
Merge remote-tracking branch 'origin/develop' into xsmall
sfc-gh-tteixeira 4fefdeb
Merge remote-tracking branch 'origin/develop' into xsmall
sfc-gh-tteixeira 044b20a
Remove duplicate test
sfc-gh-tteixeira c7680b1
Fix typing
sfc-gh-tteixeira e7d57f4
Merge remote-tracking branch 'origin/develop' into xsmall
sfc-gh-tteixeira File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file modified
BIN
-4 Bytes
(100%)
...t/__snapshots__/linux/st_columns_test/st_columns-column_gap_large[chromium].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-8 Bytes
(100%)
...ht/__snapshots__/linux/st_columns_test/st_columns-column_gap_large[firefox].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+20 Bytes
(100%)
...t/__snapshots__/linux/st_columns_test/st_columns-column_gap_medium[firefox].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+7 Bytes
(100%)
...ht/__snapshots__/linux/st_columns_test/st_columns-column_gap_none[chromium].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-38 Bytes
(99%)
...ght/__snapshots__/linux/st_columns_test/st_columns-column_gap_none[firefox].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-28 Bytes
(98%)
...ight/__snapshots__/linux/st_columns_test/st_columns-column_gap_none[webkit].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-14 Bytes
(99%)
...ght/__snapshots__/linux/st_columns_test/st_columns-column_gap_small[webkit].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.04 KB
.../__snapshots__/linux/st_columns_test/st_columns-column_gap_xlarge[chromium].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+3.22 KB
...t/__snapshots__/linux/st_columns_test/st_columns-column_gap_xlarge[firefox].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.4 KB
...ht/__snapshots__/linux/st_columns_test/st_columns-column_gap_xlarge[webkit].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.24 KB
.../__snapshots__/linux/st_columns_test/st_columns-column_gap_xsmall[chromium].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+3.94 KB
...t/__snapshots__/linux/st_columns_test/st_columns-column_gap_xsmall[firefox].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.34 KB
...ht/__snapshots__/linux/st_columns_test/st_columns-column_gap_xsmall[webkit].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1005 Bytes
...__snapshots__/linux/st_columns_test/st_columns-column_gap_xxlarge[chromium].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+3.07 KB
.../__snapshots__/linux/st_columns_test/st_columns-column_gap_xxlarge[firefox].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.14 KB
...t/__snapshots__/linux/st_columns_test/st_columns-column_gap_xxlarge[webkit].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.17 KB
...__snapshots__/linux/st_columns_test/st_columns-column_gap_xxsmall[chromium].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+3.69 KB
.../__snapshots__/linux/st_columns_test/st_columns-column_gap_xxsmall[firefox].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.43 KB
...t/__snapshots__/linux/st_columns_test/st_columns-column_gap_xxsmall[webkit].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-5 Bytes
(100%)
...t/__snapshots__/linux/st_columns_test/st_columns-nested_one_level[chromium].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+8 Bytes
(100%)
...ht/__snapshots__/linux/st_columns_test/st_columns-nested_one_level[firefox].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-2 Bytes
(100%)
...ght/__snapshots__/linux/st_columns_test/st_columns-nested_one_level[webkit].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+79 Bytes
(100%)
...hots__/linux/st_columns_test/st_columns-vertical_alignment_bottom[chromium].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-15 Bytes
(100%)
...shots__/linux/st_columns_test/st_columns-vertical_alignment_bottom[firefox].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-209 Bytes
(98%)
...pshots__/linux/st_columns_test/st_columns-vertical_alignment_bottom[webkit].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+319 Bytes
(110%)
...hots__/linux/st_columns_test/st_columns-vertical_alignment_center[chromium].png
Oops, something went wrong.
Binary file modified
BIN
+6 Bytes
(100%)
...shots__/linux/st_columns_test/st_columns-vertical_alignment_center[firefox].png
Oops, something went wrong.
Binary file modified
BIN
-207 Bytes
(97%)
...pshots__/linux/st_columns_test/st_columns-vertical_alignment_center[webkit].png
Oops, something went wrong.
Binary file modified
BIN
+361 Bytes
(110%)
...apshots__/linux/st_columns_test/st_columns-vertical_alignment_top[chromium].png
Oops, something went wrong.
Binary file modified
BIN
+31 Bytes
(100%)
...napshots__/linux/st_columns_test/st_columns-vertical_alignment_top[firefox].png
Oops, something went wrong.
Binary file modified
BIN
-136 Bytes
(99%)
...snapshots__/linux/st_columns_test/st_columns-vertical_alignment_top[webkit].png
Oops, something went wrong.
Binary file modified
BIN
-4 Bytes
(100%)
...hots__/linux/st_columns_test/st_columns-width_configuration_fixed[chromium].png
Oops, something went wrong.
Binary file modified
BIN
-21 Bytes
(100%)
...shots__/linux/st_columns_test/st_columns-width_configuration_fixed[firefox].png
Oops, something went wrong.
Binary file modified
BIN
+2 Bytes
(100%)
...pshots__/linux/st_columns_test/st_columns-width_configuration_fixed[webkit].png
Oops, something went wrong.
Binary file modified
BIN
-79 Bytes
(97%)
...ts__/linux/st_columns_test/st_columns-width_configuration_stretch[chromium].png
Oops, something went wrong.
Binary file modified
BIN
+13 Bytes
(100%)
...ots__/linux/st_columns_test/st_columns-width_configuration_stretch[firefox].png
Oops, something went wrong.
Binary file modified
BIN
+2 Bytes
(100%)
...hots__/linux/st_columns_test/st_columns-width_configuration_stretch[webkit].png
Oops, something went wrong.
Binary file modified
BIN
+6 Bytes
(100%)
...test/st_layouts_container_gap_size-container-horizontal-gap-large[chromium].png
Oops, something went wrong.
Binary file modified
BIN
-7 Bytes
(100%)
...est/st_layouts_container_gap_size-container-horizontal-gap-medium[chromium].png
Oops, something went wrong.
Binary file modified
BIN
-7 Bytes
(100%)
...test/st_layouts_container_gap_size-container-horizontal-gap-medium[firefox].png
Oops, something went wrong.
Binary file modified
BIN
-7 Bytes
(100%)
..._test/st_layouts_container_gap_size-container-horizontal-gap-none[chromium].png
Oops, something went wrong.
Binary file modified
BIN
-39 Bytes
(99%)
...e_test/st_layouts_container_gap_size-container-horizontal-gap-none[firefox].png
Oops, something went wrong.
Binary file modified
BIN
+9 Bytes
(100%)
...test/st_layouts_container_gap_size-container-horizontal-gap-small[chromium].png
Oops, something went wrong.
Binary file modified
BIN
-2 Bytes
(100%)
..._test/st_layouts_container_gap_size-container-horizontal-gap-small[firefox].png
Oops, something went wrong.
Binary file added
BIN
+2.25 KB
...est/st_layouts_container_gap_size-container-horizontal-gap-xlarge[chromium].png
Oops, something went wrong.
Binary file added
BIN
+4.36 KB
...test/st_layouts_container_gap_size-container-horizontal-gap-xlarge[firefox].png
Oops, something went wrong.
Binary file added
BIN
+2.97 KB
..._test/st_layouts_container_gap_size-container-horizontal-gap-xlarge[webkit].png
Oops, something went wrong.
Binary file added
BIN
+2.25 KB
...est/st_layouts_container_gap_size-container-horizontal-gap-xsmall[chromium].png
Oops, something went wrong.
Binary file added
BIN
+4.09 KB
...test/st_layouts_container_gap_size-container-horizontal-gap-xsmall[firefox].png
Oops, something went wrong.
Binary file added
BIN
+2.95 KB
..._test/st_layouts_container_gap_size-container-horizontal-gap-xsmall[webkit].png
Oops, something went wrong.
Binary file added
BIN
+2.27 KB
...st/st_layouts_container_gap_size-container-horizontal-gap-xxlarge[chromium].png
Oops, something went wrong.
Binary file added
BIN
+4.2 KB
...est/st_layouts_container_gap_size-container-horizontal-gap-xxlarge[firefox].png
Oops, something went wrong.
Binary file added
BIN
+2.96 KB
...test/st_layouts_container_gap_size-container-horizontal-gap-xxlarge[webkit].png
Oops, something went wrong.
Binary file added
BIN
+2.26 KB
...st/st_layouts_container_gap_size-container-horizontal-gap-xxsmall[chromium].png
Oops, something went wrong.
Binary file added
BIN
+4.02 KB
...est/st_layouts_container_gap_size-container-horizontal-gap-xxsmall[firefox].png
Oops, something went wrong.
Binary file added
BIN
+2.95 KB
...test/st_layouts_container_gap_size-container-horizontal-gap-xxsmall[webkit].png
Oops, something went wrong.
Binary file modified
BIN
-110 Bytes
(97%)
...e_test/st_layouts_container_gap_size-container-vertical-gap-large[chromium].png
Oops, something went wrong.
Binary file modified
BIN
+172 Bytes
(100%)
...ze_test/st_layouts_container_gap_size-container-vertical-gap-large[firefox].png
Oops, something went wrong.
Binary file modified
BIN
-106 Bytes
(97%)
..._test/st_layouts_container_gap_size-container-vertical-gap-medium[chromium].png
Oops, something went wrong.
Binary file modified
BIN
-106 Bytes
(96%)
...e_test/st_layouts_container_gap_size-container-vertical-gap-small[chromium].png
Oops, something went wrong.
Binary file modified
BIN
+11 Bytes
(100%)
...ze_test/st_layouts_container_gap_size-container-vertical-gap-small[firefox].png
Oops, something went wrong.
Binary file added
BIN
+3.45 KB
..._test/st_layouts_container_gap_size-container-vertical-gap-xlarge[chromium].png
Oops, something went wrong.
Binary file added
BIN
+7.28 KB
...e_test/st_layouts_container_gap_size-container-vertical-gap-xlarge[firefox].png
Oops, something went wrong.
Binary file added
BIN
+4.25 KB
...ze_test/st_layouts_container_gap_size-container-vertical-gap-xlarge[webkit].png
Oops, something went wrong.
Binary file added
BIN
+2.67 KB
..._test/st_layouts_container_gap_size-container-vertical-gap-xsmall[chromium].png
Oops, something went wrong.
Binary file added
BIN
+4.72 KB
...e_test/st_layouts_container_gap_size-container-vertical-gap-xsmall[firefox].png
Oops, something went wrong.
Binary file added
BIN
+3.31 KB
...ze_test/st_layouts_container_gap_size-container-vertical-gap-xsmall[webkit].png
Oops, something went wrong.
Binary file added
BIN
+3.72 KB
...test/st_layouts_container_gap_size-container-vertical-gap-xxlarge[chromium].png
Oops, something went wrong.
Binary file added
BIN
+8.2 KB
..._test/st_layouts_container_gap_size-container-vertical-gap-xxlarge[firefox].png
Oops, something went wrong.
Binary file added
BIN
+4.58 KB
...e_test/st_layouts_container_gap_size-container-vertical-gap-xxlarge[webkit].png
Oops, something went wrong.
Binary file added
BIN
+2.62 KB
...test/st_layouts_container_gap_size-container-vertical-gap-xxsmall[chromium].png
Oops, something went wrong.
Binary file added
BIN
+4.59 KB
..._test/st_layouts_container_gap_size-container-vertical-gap-xxsmall[firefox].png
Oops, something went wrong.
Binary file added
BIN
+3.25 KB
...e_test/st_layouts_container_gap_size-container-vertical-gap-xxsmall[webkit].png
Oops, something went wrong.
Binary file modified
BIN
+9 Bytes
(100%)
...t/__snapshots__/linux/st_space_test/st_space_horizontal_container[chromium].png
Oops, something went wrong.
Binary file modified
BIN
+38 Bytes
(100%)
...ht/__snapshots__/linux/st_space_test/st_space_horizontal_container[firefox].png
Oops, something went wrong.
Binary file modified
BIN
-1 Byte
(100%)
...ight/__snapshots__/linux/st_space_test/st_space_nested_containers[chromium].png
Oops, something went wrong.
Binary file modified
BIN
-7 Bytes
(100%)
...right/__snapshots__/linux/st_space_test/st_space_nested_containers[firefox].png
Oops, something went wrong.
Binary file modified
BIN
+22 Bytes
(100%)
...apshots__/linux/st_space_test/st_space_vertical_container_stretch[chromium].png
Oops, something went wrong.
Binary file modified
BIN
+19 Bytes
(100%)
...napshots__/linux/st_space_test/st_space_vertical_container_stretch[firefox].png
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.