[Fix] auth type issue caused by dependency update #13424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
✅ PR preview is ready!
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes an unnecessary # type: ignore[override] comment from the load_config method in the TornadoIntegration class. The comment was previously needed because the parent class in types-authlib 1.6.6.20251214 defined load_config with a return type of None, which conflicted with this override's return type of dict[str, Any]. The dependency update to types-authlib 1.6.6.20251220 changed the parent's return type to Any, making the type ignore comment unnecessary.
Key Changes
- Removed
# type: ignore[override]from theload_configmethod signature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Nightly failed due to update in
types-authlibdependency (from1.6.6.20251214to1.6.6.20251220- see here). See passing run based on commit here and failing nightly run based on the same commit here.The return type for the
load_config' function - which we override instreamlit/web/server/authlib_tornado_integration.py- was updated fromNoneto implicitlyAny`.Our override return value of
dict[str, Any]previously needed# type: ignore[override]to suppress the error, but with the newAnyreturn value this is no longer necessary.